Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix positioning of activities in the activities list #4438

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Fix positioning of activities in the activities list #4438

merged 1 commit into from
Apr 21, 2022

Conversation

claucambra
Copy link
Collaborator

This PR removes activity spacing in the activity list view and fixes the activity label alignment, which is now ensured to be centred

Screenshot 2022-04-14 at 00 28 14

@claucambra claucambra self-assigned this Apr 13, 2022
jancborchardt
jancborchardt approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, much better design-wise :)

@karlitschek
Copy link
Member

Yes. Looks a lot better

@claucambra claucambra force-pushed the bugfix/activity-list-positioning branch from 177a600 to e605520 Compare April 18, 2022 17:34
@mgallien
Copy link
Collaborator

/rebase

@claucambra @mgallien
Removed spacing between activies, labels now centre-aligned
1507826 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@mgallien mgallien force-pushed the bugfix/activity-list-positioning branch from e605520 to 1507826 Compare April 20, 2022 16:07
@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4438-15078260b4b8e46421274be415b4474ae7ef5a02-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@claucambra claucambra merged commit 8269601 into master Apr 21, 2022
@claucambra claucambra deleted the bugfix/activity-list-positioning branch April 21, 2022 22:59
@mgallien mgallien added this to the 3.5.0 milestone Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@camilasan camilasan Awaiting requested review from camilasan

@allexzander allexzander Awaiting requested review from allexzander

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@claucambra @karlitschek @mgallien @nextcloud-desktop-bot @jancborchardt