[stable-3.9] always propagate locked status to read-only or read/write for real file #5883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
make sure that a file locked that would not be modifiable by the current client is read-only on storage also make sure we make a file read/write when modification can happen again Close #5537 Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
should help investigate failure for automated tests Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
we try to preserve complex existing permissions unless the client is required to change them significantly Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
will fix behavior on windows by properly setting the new temp file just downloaded have the proper state (read only or read/write) and not the already existing file that will be replaced by the newly odwnloaded one Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
claucambra
approved these changes
Jul 12, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## stable-3.9 #5883 +/- ##
==============================================
+ Coverage 60.41% 60.48% +0.06%
==============================================
Files 145 145
Lines 18605 18612 +7
==============================================
+ Hits 11241 11258 +17
+ Misses 7364 7354 -10
|
|
AppImage file: nextcloud-PR-5883-55d64432cda336b87c2a4e0ef8640f2576613cf2-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5841