Support the KF6 based version of Dolphin #6320
Conversation
er-vin
requested review from
mgallien,
camilasan,
nicolasfella,
allexzander and
claucambra
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
er-vin
force-pushed
the
work/ervin/support-kf6-based-dolphin
branch
from
5cfbf32
to
89bf79c
Compare
|
Do we agree that the clang-tidy, windows and mac build are false positives? If someone confirms I'll go ahead, ignoring them, and merging this PR. |
yes they are false positive |
We remove one unused include which will disappear in KF6. Also we switch to camel case includes without the module prefix. Signed-off-by: Kevin Ottens <ervin@kde.org>
Signed-off-by: Kevin Ottens <ervin@kde.org>
Signed-off-by: Kevin Ottens <ervin@kde.org>
Signed-off-by: Kevin Ottens <ervin@kde.org>
The desktop to json conversion step will disappear with KF6 Signed-off-by: Kevin Ottens <ervin@kde.org>
Now if KF6 KIO is present, we build the Dolphin plugin against the Qt6 version of everything. Otherwise we keep assuming the Qt5 version of the platform. Signed-off-by: Kevin Ottens <ervin@kde.org>
er-vin
force-pushed
the
work/ervin/support-kf6-based-dolphin
branch
from
89bf79c
to
38b59a8
Compare
|
AppImage file: nextcloud-PR-6320-38b59a82bf8a4f6007f1eac2906ae3957e46eba7-x86_64.AppImage |
|
|
Hi, I'm a KDE Neon User, I use de the release 3.13.0 of dolphin-nextcloud (installed with Nextcloud PPA) that should work properly with Plasma 6 (QT6/KF6), but I still don't have the sync indicators on files and no context menu in Dolphin (cf. my downstream ticket: https://bugs.kde.org/show_bug.cgi?id=483423#c2). Am I the only one? |
This is not a Qt6 port of the whole client. Still, KF6 based Dolphin is around the corner so make sure it will still benefit from the shell integration plugin.
This PR does some stylistic changes and cleanups to the code but this is mainly here to help the transition to the Qt6/KF6 build which seems a bit stricter by default than older versions.
The real important part of the work is the CMake adjustments and trying to detect both KF5 and KF6 KIO versions to figure out what's around.
Important: My current setup doesn't make it easy to test Qt5 and Qt6 based builds in parallel. So some more extensive testing from someone with a more traditional setup is likely welcome.