Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/expandable folder status model #6490

Merged
merged 11 commits into from
Mar 5, 2024

Conversation

claucambra
Copy link
Collaborator

Two things in this PR:

  1. Code cleanup in general across FolderStatusModel
  2. Fetch the first level of folders from root, fixing "fake" expandable folders

Fixes following bug:

Attachment.file.1.treeview.mov

src/gui/folderstatusmodel.cpp Outdated Show resolved Hide resolved
src/gui/folderstatusmodel.cpp Outdated Show resolved Hide resolved
src/gui/folderstatusmodel.cpp Outdated Show resolved Hide resolved
src/gui/folderstatusmodel.cpp Outdated Show resolved Hide resolved
src/gui/folderstatusmodel.cpp Outdated Show resolved Hide resolved
src/gui/folderstatusmodel.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@allexzander allexzander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Kindly, fix the CI compile error and squash whatever makes sense (at least review comment fixes into one).

@claucambra claucambra force-pushed the bugfix/expandable-folder-status-model branch from dcb8581 to 513b32e Compare March 3, 2024 18:21
@claucambra
Copy link
Collaborator Author

Great. Kindly, fix the CI compile error and squash whatever makes sense (at least review comment fixes into one).

Thanks, fixed the CI error and squashed some commits

@claucambra claucambra enabled auto-merge (rebase) March 4, 2024 10:05
@claucambra
Copy link
Collaborator Author

/backport to stable-3.12

…model

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…r status model

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra claucambra force-pushed the bugfix/expandable-folder-status-model branch from 513b32e to e15252a Compare March 5, 2024 03:48
@claucambra claucambra merged commit 0826df7 into master Mar 5, 2024
9 of 12 checks passed
@claucambra claucambra deleted the bugfix/expandable-folder-status-model branch March 5, 2024 03:50
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6490-e15252a88c8f0d009a1f990dac059402c9f3170f-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mgallien mgallien added this to the 3.13.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants