Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-3.12] Bugfix/expandable folder status model #6505

Merged
merged 11 commits into from Mar 5, 2024
Merged

[stable-3.12] Bugfix/expandable folder status model #6505

merged 11 commits into from Mar 5, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Mar 5, 2024

Backport of PR #6490

@claucambra @backportbot
Modernise and replace foreach loops with for in loops in folderstatus…
58d798b 
…model

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @backportbot
Fix undecided lists in fodlerstatusmodel comment
c2123bb 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @backportbot
Avoid excessive single letter variables in FolderStatusModel
626b795 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @backportbot
Const autofy where possible in folderstatusmodel
f7a4f8e 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @backportbot
Use braced initialiser where possible for folderstatusmodel
0fd4210 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @backportbot
Automatically fetch first level of subfolders for root nodes in folde…
47c088c 
…r status model

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @backportbot
Clarify role of idx in slotUpdateDirectories
a996fb8 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @backportbot
Clean up and add braces for if statements in folderstatusmodel
72e36c9 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @backportbot
Remove unneeded error variable
fbc6b2b 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @backportbot
Check parent variable nullness in folderstatusmodel
6b2abd5 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @backportbot
Ensure there is a return in case FolderPathRole of FolderStatusModel
0c759cd 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@backportbot backportbot bot added this to the 3.12.1 milestone Mar 5, 2024
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6505-0c759cd5a3b62ad15f976bf4d18249fd592eed7d-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
12 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@claucambra claucambra merged commit e35974d into stable-3.12 Mar 5, 2024
10 of 13 checks passed
@claucambra claucambra deleted the backport/6490/stable-3.12 branch March 5, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@allexzander allexzander Awaiting requested review from allexzander

Assignees

@claucambra claucambra

Labels
3. to review
Projects
None yet
Milestone
3.12.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nextcloud-desktop-bot @claucambra