Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 autocreate is a no-op while verify_bucket_exists isn't documented but is nearly equivalent *except* it defaults to true #10436

Closed
joshtrichards opened this issue May 25, 2023 · 1 comment

Comments

@joshtrichards
Copy link
Member

Interrelated issues that are, at a minimum, documentation matters and, potentially, nextcloud/server matters.

  • autocreate is in the doc examples for s3, but never actually used in the S3 ObjectStore code so it's a no-op (unlike with Swift and Azure which use it if specified in config.php)
  • autocreate always defaults to false in the Object Stores that support it
  • verify_bucket_exists isn't documented for s3 in terms of purpose, but does appear once in the S3 SSE-C encryption support example. It appears to be the closest counterpart to autocreate with one major exception (last item below)
  • In the S3 ObjectStore code verify_bucket_exists behaves similarly to autocreate (it creates the bucket if it doesn't already exist)
  • In the S3 ObjectStore code verify_bucket_exists always defaults to true - unlike autocreate - unless overridden in config.php
@joshtrichards
Copy link
Member Author

Went ahead and documented in #10437 as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant