fix(s3): fix handling verify_bucket_exists parameter #39017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcitworld
requested review from
icewind1991,
juliushaertl,
a team,
ArtificialOwl and
Fenn-CS
and removed request for
a team
|
/backport to stable27 |
|
/backport to stable26 |
|
/backport to stable25 |
joshtrichards
approved these changes
Jul 2, 2023
There was a problem hiding this comment.
Good catch.
Documentation covered few weeks back in nextcloud/documentation#10437 & nextcloud/documentation#10436
|
There are also (some # of) installations out there with Probably too late (risky) to make that parameter equivalent now without blowback. Also, probably not a big deal as long as it: (a) now works (b) the correct parameter is now documented. |
juliushaertl
approved these changes
Jul 10, 2023
juliushaertl
force-pushed
the
fix/s3/verify_bucket_exists
branch
from
f208387
to
6df781e
Compare
juliushaertl
added
4. to release
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
I've marked the above messages off-topic as the bug was present from the very beginning this feature (and the parameter) was introduced. |
susnux
approved these changes
Aug 2, 2023
susnux
force-pushed
the
fix/s3/verify_bucket_exists
branch
from
6df781e
to
c2fc3b8
Compare
kesselb
force-pushed
the
fix/s3/verify_bucket_exists
branch
from
c2fc3b8
to
3726f3f
Compare
If 'verify_bucket_exists' is set to false in the config.php s3 configuration, it's supposed to avoid verifying that the bucket exists. However empty(falsy) will always return true, so this condition would not work. Signed-off-by: Thomas Citharel <tcit@tcit.fr>
kesselb
force-pushed
the
fix/s3/verify_bucket_exists
branch
from
3726f3f
to
3f28fc5
Compare
This was referenced Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
'verify_bucket_exists'is set to false in theconfig.phps3 configuration, it's supposed to avoid verifying that the bucket exists. Howeverempty(falsy)will always return true, so this condition would not work.Follow-up to #23932
Checklist