Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(admin): Clarify DB conversion steps and command usage #11584

Merged
merged 10 commits into from Feb 26, 2024

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Feb 25, 2024

This clarifies the conversion process significantly, based on a mixture of help forum interactions and my own testing. Namely:

  • Make it clearer you should set-up your target database first
  • Link to respective db configuration sections so reader sees how to add new target db + credentials
  • List type parameters supported
  • Clarify process/steps
  • New call-outs where appropriate
  • Add that mysql.utf8mb4 parameter should get set to true after converting (if targeting MariaDB/MySQL)
  • General clarifications and language adjustments

☑️ Resolves

Also:

Follow-up note: I'll add language in a follow-on PR for UNIX socket usage when that gets fixed in server (nextcloud/server#31998) - i.e. when I finish nextcloud/server#39242 probably.

🖼️ Screenshots

image

Signed-off-by: Josh <josh.t.richards@gmail.com>
Fixes #7341 

Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards merged commit 508aa2f into master Feb 26, 2024
11 checks passed
@joshtrichards joshtrichards deleted the docs/admin/db-conversion-steps branch February 26, 2024 15:21
@joshtrichards
Copy link
Member Author

/backport to stable28

@joshtrichards
Copy link
Member Author

/backport to stable27

Copy link

backportbot bot commented Feb 26, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/11584/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2874107d a2fa5857 58f5f572 23e6fb02 ee7c2ba0 5f4ba48e 16e1b357 c66db26c e900d173 fd84d8cb

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/11584/stable28

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Feb 26, 2024

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b backport/11584/stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2874107d a2fa5857 58f5f572 23e6fb02 ee7c2ba0 5f4ba48e 16e1b357 c66db26c e900d173 fd84d8cb

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/11584/stable27

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

acataluddi pushed a commit to acataluddi/nextcloud-documentation that referenced this pull request Apr 28, 2024
…#11584)

Signed-off-by: Josh <josh.t.richards@gmail.com>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Adriano Cataluddi <acataluddi@gmail.com>
@nextcloud nextcloud deleted a comment from github-actions bot May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document valid strings for occ:convert-type database type
2 participants