(occ db:convert-type) Add support for UNIX sockets

[joshtrichards]

Adds support to occ db:convert-type to support UNIX socket connections via MySQL/MariaDB:

• Uses same dbhost / hostname parameter parsing logic (adapted) as used elsewhere (at least the relevant parts) for consistency.

• Adds UI support for non-passworded connections.

• Resolves: # [Bug]: db:convert-type does not support mysql passwordless unix socket auth #31998

Summary

TODO

• ...

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[Fenn-CS]

Suggested change

	if (strpos($input->getOption('hostname'), ':') !== false) {
	// Host variable may carry a socket (or port)
	[$host, $portOrSocket] = explode(':', $input->getOption('hostname'), 2);
	if (ctype_digit($portOrSocket)) {
	$connectionParams['port'] = $portOrSocket; // to be consistent with how we handle this elsewhere we accept this too but don't document it
	} else {
	$connectionParams['unix_socket'] = $portOrSocket;
	}
	$connectionParams['host'] = $host;
	}
	if (preg_match('/^(.+)(:(\d+|[^:]+))?$/',$input->getOption('hostname'), $matches)) {
	$connectionParams['host'] = $matches[1];
	if (isset($matches[3])) {
	if (is_numeric($matches[3])) {
	$connectionParams['port'] = $matches[3];
	} else {
	$connectionParams['unix_socket'] = $matches[3];
	}
	}
	}

Suggestion :

Using regex is most likely better than explode. /^(.+):(\d+|[^:]+)$/ matches a string that starts with one or more characters ((.+)) followed by a colon (:) and then either a numeric value (\d+) or one or more non-colon characters ([^:]+) until the end of the string ($).

The regular expression approach allows you to extract the host name and port number or socket path in a single step, which is more concise than using explode() and ctype_digit(). Additionally, it allows for more flexibility in the format of the option value.

[Fenn-CS]

I did not copy the comments but they are relevant.

[Fenn-CS]

Looks okay though I left an inline suggestion. Do you mind using regex instead?