Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make groupfolders more visible #38

Closed
10 of 13 tasks
tobiasKaminsky opened this issue Apr 5, 2023 · 14 comments
Closed
10 of 13 tasks

Make groupfolders more visible #38

tobiasKaminsky opened this issue Apr 5, 2023 · 14 comments
Assignees

Comments

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Apr 5, 2023

Goal is to give our groupfolder system more visibility.

  • Retrieve all folders that are groupfolders, API is pending
  • in capabilities: groupfolder for user: yes/no
  • icon: shared folder icon, might be replaced by another one

Android @tobiasKaminsky:

  • in navigation, beneath "Shared": new entry "Groupfolders"
  • show list of available groupfolders, on click navigate to it

Desktop @mgallien:

  • in tray menu: folder icon will become dropdown
    • first entry: "main folder"
    • then list all groupfolders -> click on it opens folder (if synced, else explain it)
    • if only one entry -> do not show dropdown

iOS @marinofaggiana:

  • in "more" -> "Groupfolders"
  • show list of available groupfolders, on click navigate to it
@mgallien
Copy link
Contributor

mgallien commented Apr 6, 2023

@tobiasKaminsky do you have a mock up of what it would look like ?
we currently handle them like external storage so if they are selected the activity from them would already appear in the activity list
maybe I misunderstand something here

@tobiasKaminsky
Copy link
Member Author

image

It is about this view and about "folder" icon (the one with green sync icon).
On Desktop it is basically to have a shortcut to those groupfolders.

@marinofaggiana
Copy link
Member

Is in WIP the capabilities: groupfolder for user: yes/no ?? because in NC26 is not present (yet)

@tobiasKaminsky
Copy link
Member Author

Will be at some point in groupfolders app, and then we can use it.
Might be backported to NC26, but clients shall only rely on capability.

@marinofaggiana
Copy link
Member

Simulator Screenshot - iPhone 14 - 2023-04-13 at 15 26 42
Simulator Screenshot - iPhone 14 - 2023-04-13 at 15 26 48

I would propose the addition in share (like server)

Screenshot 2023-04-13 alle 15 27 47

@tobiasKaminsky
Copy link
Member Author

Let us first do the minimum, and if time allows, we can add this to share handling.

@tobiasKaminsky
Copy link
Member Author

tobiasKaminsky commented Apr 17, 2023

},
				"groupfolders": {
					"hasGroupFolders": true
				},

We have on e2e.kaminsky.me, user "tag" this now active.
So we can do:

  • if property is not available (<NC27) or "false" -> do not show entry / dropdown
  • if property is "true" -> use it

@tobiasKaminsky
Copy link
Member Author

@marinofaggiana @mgallien ^

@marinofaggiana
Copy link
Member

marinofaggiana commented Apr 17, 2023

@tobiasKaminsky:
in my NC26 for NOT admin:

GET https://nextcloud.homelinux.org/index.php/apps/groupfolders/folders
error 500 < {"message":"Logged in user must be an admin, a sub admin or gotten special right to access this setting"} >

as admin group, no problem.

@tobiasKaminsky
Copy link
Member Author

This is not yet in NC26, thus please use e2e.kaminsky.me server, where all needed PRs are applied.

@tobiasKaminsky
Copy link
Member Author

@marinofaggiana @mgallien
in request to list groupfolders please add applicable=1, as this then shows also for admin user correct info:
/index.php/apps/groupfolders/folders?applicable=1

@tobiasKaminsky
Copy link
Member Author

@jancborchardt when we first spoke about this feature, you mentioned that icon might change.
So, will we have a new icon? :)

@allexzander allexzander assigned allexzander and unassigned mgallien Apr 21, 2023
@tobiasKaminsky
Copy link
Member Author

Capability:

	"groupfolders": {
					"hasGroupFolders": true
				},

List of groupfolders:
curl --request GET
--url 'https://e2e.kaminsky.me/index.php/apps/groupfolders/folders?format=json&applicable=1'
--header 'OCS-APIRequest: true'

output:

{
	"ocs": {
		"meta": {
			"status": "ok",
			"statuscode": 100,
			"message": "OK",
			"totalitems": "",
			"itemsperpage": ""
		},
		"data": {
			"1": {
				"id": 1,
				"mount_point": "\/groupfolder",
				"groups": {
					"users": 31
				},
				"quota": -3,
				"size": 1896240,
				"acl": false,
				"manage": []
			},
			"2": {
				"id": 2,
				"mount_point": "\/subfolder\/group",
				"groups": {
					"users": 31
				},
				"quota": -3,
				"size": 2604768,
				"acl": false,
				"manage": []
			}
		}
	}
}

@tobiasKaminsky
Copy link
Member Author

All done.

@jancborchardt jancborchardt self-assigned this Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

No branches or pull requests

5 participants