-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow non-admins to list their own groupfolders #2327
Conversation
Should we somehow also limit the listing for the admin for the cases where this is used in the clients or files app? Otherwise for admins and delegated admins it would list all folders, also those that are not accessible through the filesystem just for group folder management. https://github.com/nextcloud/groupfolders/pull/2326/files seems much cleaner for that approach, but as I understood clients would prefer ocs, right? Maybe we can just have separate endpoints for the user scoped list. |
Yes, ocs is better than webdav in this case, as we only want to use these folders as shortcuts to our regular webdav. Good point with admin, so a separate endpoint is indeed better. |
Would we want/need brute force / throttling on them ? cc @nickvergessen since we lately discussed this and touch endpoints here. |
I don't have troubles with listing them. Listing does not DDoS/load other users, so that should be fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good codewise, not sure about Julius remark.
Signed-off-by: Robin Appelman <robin@icewind.nl>
9b6cfca
to
b18e2d9
Compare
Added an option to filter the listing response for admins by adding |
Signed-off-by: Robin Appelman <robin@icewind.nl>
b18e2d9
to
5453916
Compare
Allow regular users access to
GET apps/groupfolders/folders
GET apps/groupfolders/folders/$folderId
They only see groupfolders they have access to and only the permissions for groups they belong to