Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to read Groupfolders #1109

Merged
merged 12 commits into from
May 8, 2023
Merged

Support to read Groupfolders #1109

merged 12 commits into from
May 8, 2023

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Apr 13, 2023

@github-actions
Copy link

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

@github-actions
Copy link

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

@github-actions
Copy link

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

@github-actions
Copy link

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

@github-actions
Copy link

github-actions bot commented May 3, 2023

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

@github-actions
Copy link

github-actions bot commented May 3, 2023

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

@tobiasKaminsky tobiasKaminsky marked this pull request as ready for review May 3, 2023 08:36
@github-actions github-actions bot deleted a comment from nextcloud-android-bot May 3, 2023
@github-actions
Copy link

github-actions bot commented May 3, 2023

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

@AndyScherzinger
Copy link
Member

looks good to me except for the v26 check, not sure that is correct, but didn't check the server-side of things.

@github-actions
Copy link

github-actions bot commented May 3, 2023

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

@github-actions github-actions bot deleted a comment from nextcloud-android-bot May 3, 2023
@github-actions
Copy link

github-actions bot commented May 3, 2023

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

@github-actions github-actions bot deleted a comment from nextcloud-android-bot May 4, 2023
@github-actions
Copy link

github-actions bot commented May 4, 2023

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

AndyScherzinger
AndyScherzinger previously approved these changes May 4, 2023
@github-actions
Copy link

github-actions bot commented May 4, 2023

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

@github-actions
Copy link

github-actions bot commented May 4, 2023

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

@github-actions
Copy link

github-actions bot commented May 5, 2023

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 38
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 6
Dodgy code Warnings 26
Total 131

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 38
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 6
Dodgy code Warnings 26
Total 131

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
AndyScherzinger
AndyScherzinger previously approved these changes May 8, 2023
@github-actions
Copy link

github-actions bot commented May 8, 2023

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 38
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 6
Dodgy code Warnings 26
Total 131

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 38
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 6
Dodgy code Warnings 26
Total 131

@github-actions
Copy link

github-actions bot commented May 8, 2023

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 38
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 6
Dodgy code Warnings 26
Total 131

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 38
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 6
Dodgy code Warnings 26
Total 131

@github-actions
Copy link

github-actions bot commented May 8, 2023

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 38
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 6
Dodgy code Warnings 26
Total 131

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 38
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 6
Dodgy code Warnings 26
Total 131

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@github-actions
Copy link

github-actions bot commented May 8, 2023

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 38
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 6
Dodgy code Warnings 26
Total 131

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 38
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 6
Dodgy code Warnings 26
Total 131

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #1109 (83b9a2b) into master (677f144) will increase coverage by 0.86%.
The diff coverage is 65.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1109      +/-   ##
==========================================
+ Coverage   50.64%   51.51%   +0.86%     
==========================================
  Files         185      187       +2     
  Lines        6838     6880      +42     
  Branches      907      911       +4     
==========================================
+ Hits         3463     3544      +81     
+ Misses       2885     2844      -41     
- Partials      490      492       +2     
Impacted Files Coverage Δ
.../android/lib/resources/groupfolders/Groupfolder.kt 25.00% <25.00%> (ø)
...sources/status/GetCapabilitiesRemoteOperation.java 50.16% <57.14%> (+1.17%) ⬆️
...ces/groupfolders/GetGroupfoldersRemoteOperation.kt 66.66% <66.66%> (ø)
...cloud/android/lib/resources/status/OCCapability.kt 93.44% <100.00%> (+0.46%) ⬆️

... and 11 files with indirect coverage changes

@AndyScherzinger AndyScherzinger self-requested a review May 8, 2023 10:01
@AndyScherzinger AndyScherzinger merged commit 1b861ad into master May 8, 2023
19 checks passed
@delete-merged-branch delete-merged-branch bot deleted the groupfolders branch May 8, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants