Fix download button shown in public share page with hidden downloads #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The download buttons are now hidden using JavaScript when the PDF viewer is loaded in the public share page if the share has the "Hide download" option enabled; this needs to be done in JavaScript instead of in the template as in the template there is no access to that option. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
|
/backport to stable16 |
|
/backport to stable15 |
ChristophWurst
approved these changes
Jun 27, 2019
28 tasks
delete-merged-branch
bot
deleted the
fix-download-button-shown-in-public-share-page-with-hidden-downloads
branch
|
backport to stable16 in #145 |
|
backport to stable15 in #146 |
|
Hello dear developers! I agree with the developers in the other posts that there is such a contradiction
Question:
I am ready to consider a commercial offer ... which I am ready to give for use by the community |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test
Result with this pull request
The download icon is not shown.
Result without this pull request
The download icon is shown.