Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix time-formatting #671

Merged
merged 2 commits into from
Nov 13, 2020
Merged

Fix time-formatting #671

merged 2 commits into from
Nov 13, 2020

Conversation

jotoeri
Copy link
Member

@jotoeri jotoeri commented Nov 12, 2020

This reincludes the moment-locales into the forms-bundle, so @nexctloud/moment can use it.

  • Allows moment to format the date on Results - Fix Inconsistent timestamp when exporting as csv #606
  • Allows moment on the new Date-QuestionType to format the date Add Date & Datetime Component #672
  • Allows moment on sidebar to format automatically, no manual loading necessary anymore.
  • Indeed, this increases forms-main bundle size from 1.95MiB to 2.15MiB, but compared to other apps (Mail 4.3MiB, Deck 2.72MiB, Contacts 2.6MiB), that still seems ok to me. However one could probably find other ways to further reduce the single-package-size.

@jotoeri jotoeri added bug Something isn't working 3. to review Waiting for reviews labels Nov 12, 2020
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@skjnldsv skjnldsv merged commit 860032c into master Nov 13, 2020
@skjnldsv skjnldsv deleted the fix/result_timestamp branch November 13, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent timestamp when exporting as csv
3 participants