Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Date & Datetime Component #672

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Add Date & Datetime Component #672

merged 1 commit into from
Nov 20, 2020

Conversation

jotoeri
Copy link
Member

@jotoeri jotoeri commented Nov 12, 2020 •
edited

Now continuing on the previous Date-PR #604

  • Based onto Fix time-formatting #671 (& includes its main-aspect), as this allows moment to format the date here
  • Merged the two Component-Files into one, as there was one line of code difference.
  • Fixed the review-stuff from the other PR
  • Now stores the selected date as String, just as the user selected it.

@jancborchardt Could you have a look onto design?

@simmstein Unfortunately i can't 'officially' request your review here, but would still be happy to get your review/opinion/test. :)

@jotoeri jotoeri added enhancement New feature or request 3. to review Waiting for reviews feature: ❓ question types labels Nov 12, 2020
@jotoeri jotoeri mentioned this pull request Nov 12, 2020
Merged
@simmstein
Copy link
Contributor

Perfect!

@jotoeri jotoeri force-pushed the enh/add_date_time branch 3 times, most recently from 5e314ad to 2596d90 Compare November 16, 2020 20:24
@skjnldsv
Copy link
Member

Please rebase & squash :)

@jotoeri
Copy link
Member Author

jotoeri commented Nov 17, 2020

@jancborchardt Anything from your side?

@simmstein @jotoeri
Add date and datetime question-type
a83db93 
Original Author: Simon Vieille <simon@deblan.fr>
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
@skjnldsv skjnldsv merged commit e98553c into master Nov 20, 2020
@skjnldsv skjnldsv deleted the enh/add_date_time branch November 20, 2020 06:28
@jotoeri jotoeri mentioned this pull request Nov 21, 2020
Closed
@u451f
Copy link

u451f commented Jan 15, 2021

Super cool that this feature was implemented! Thanks!
I don't understand in which version of NC Forms this feature is available, can you help me understand? Sorry if this is obvious and I missed it.

@u451f
Copy link

u451f commented Jan 15, 2021

Replying to myself: https://github.com/nextcloud/forms/releases/tag/v2.1.0 <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request feature: ❓ question types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jotoeri @simmstein @skjnldsv @u451f