Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stale cache when managing advanced permissions #1378

Closed
bigio opened this issue Mar 18, 2021 · 3 comments
Closed

Stale cache when managing advanced permissions #1378

bigio opened this issue Mar 18, 2021 · 3 comments
Labels
0. Needs triage Issues that need to be triaged bug feature: acl Items related to the groupfolders ACL or "Advanced Permissions" feature: caching Items related to caching integration

Comments

@bigio
Copy link

bigio commented Mar 18, 2021

After latest NextCloud update to 21.0.0 managing advanced permissions from web gui has become difficult due to stale cache.
Every time I view advanced permissions on a folder I have to force a refresh (F5 on the browser) to be able to check permissions on a different folder, otherwise the web gui will display the permissions of the last folder I view.

Cache related configuration is:

  'memcache.local' => '\\OC\\Memcache\\APCu',  
  'memcache.locking' => '\\OC\\Memcache\\Redis',  
  'memcache.distributed' => '\\OC\\Memcache\\Redis',  
  'redis' =>   
  array (  
    'host' => '127.0.0.1',  
    'port' => 6379,  
    'dbindex' => 1,  
  ),

I also tried to disable Apcu and opcache but nothing has changed.

@fschrempf fschrempf added 0. Needs triage Issues that need to be triaged feature: acl Items related to the groupfolders ACL or "Advanced Permissions" bug ui labels Mar 18, 2021
@pierreozoux pierreozoux added feature: caching Items related to caching integration labels Mar 28, 2021
@jngrb
Copy link
Contributor

jngrb commented Mar 29, 2021

I can confirm this bug. But I think it is not related to caching. There is just no refresh of the content of the SharingSidebarView (<div id="groupfolder-acl-container"...>) when a different file is selected.
Steps to reproduce:
a) Have a groupfolder with advanced permissions enabled.
b)- Have a subfolder A with a certain ACL list.
c) Have a subfolder B with certain other ACL entries.
d) Open the groupfolder with the list of subfolders.
e) Click "..." -> Details on subfolder A to load the side bar view. Go to sidebar tab "Sharing" to see the ACL entries.
f) Click "..." -> Details on subfolder B to refresh the side bar view with the details for the other folder. BUT: the ACL entries are not refreshed - they are still the entries of subfolder A.

To work around this bug, just close the side bar view with the "x" in the upper-right corner between steps e) and f). => You see the right ACL entries - those from subfolder B.

jngrb added a commit to jngrb/groupfolders that referenced this issue Mar 29, 2021
…d#1378

Details: in NC 21, the sidebar is not reloaded completely if a different
file is selected. Instead, just the props of an open sidebar view
are updated. So far, the ACL list not respond to a changed prop.
This is now changed, fixing the issue reported as nextcloud#1378.
jngrb added a commit to jngrb/groupfolders that referenced this issue Mar 29, 2021
…d#1378

Details: in NC 21, the sidebar is not reloaded completely if a different
file is selected. Instead, just the props of an open sidebar view
are updated. So far, the ACL list not respond to a changed prop.
This is now changed, fixing the issue reported as nextcloud#1378.

Signed-off-by: Jan Niklas Grieb (home) <jan.grieb@gmail.com>
@jngrb
Copy link
Contributor

jngrb commented Mar 29, 2021

I provided a patch for this: #1406

@juliushaertl , please review this PR and my other one #1395

@pierreozoux pierreozoux removed the ui label Apr 2, 2021
backportbot-nextcloud bot pushed a commit that referenced this issue Apr 9, 2021
Details: in NC 21, the sidebar is not reloaded completely if a different
file is selected. Instead, just the props of an open sidebar view
are updated. So far, the ACL list not respond to a changed prop.
This is now changed, fixing the issue reported as #1378.

Signed-off-by: Jan Niklas Grieb (home) <jan.grieb@gmail.com>
backportbot-nextcloud bot pushed a commit that referenced this issue Apr 9, 2021
Details: in NC 21, the sidebar is not reloaded completely if a different
file is selected. Instead, just the props of an open sidebar view
are updated. So far, the ACL list not respond to a changed prop.
This is now changed, fixing the issue reported as #1378.

Signed-off-by: Jan Niklas Grieb (home) <jan.grieb@gmail.com>
backportbot-nextcloud bot pushed a commit that referenced this issue Apr 9, 2021
Details: in NC 21, the sidebar is not reloaded completely if a different
file is selected. Instead, just the props of an open sidebar view
are updated. So far, the ACL list not respond to a changed prop.
This is now changed, fixing the issue reported as #1378.

Signed-off-by: Jan Niklas Grieb (home) <jan.grieb@gmail.com>
juliushaertl added a commit that referenced this issue Apr 27, 2021
[stable21] Sidebar view: refresh ACL entries when fileInfo prop changes #1378
juliushaertl pushed a commit that referenced this issue Apr 27, 2021
Details: in NC 21, the sidebar is not reloaded completely if a different
file is selected. Instead, just the props of an open sidebar view
are updated. So far, the ACL list not respond to a changed prop.
This is now changed, fixing the issue reported as #1378.

Signed-off-by: Jan Niklas Grieb (home) <jan.grieb@gmail.com>
juliushaertl added a commit that referenced this issue Apr 27, 2021
[stable20] Sidebar view: refresh ACL entries when fileInfo prop changes #1378
juliushaertl added a commit that referenced this issue Apr 27, 2021
[stable19] Sidebar view: refresh ACL entries when fileInfo prop changes #1378
@jngrb
Copy link
Contributor

jngrb commented Apr 29, 2021

@juliushaertl , this can be closed, I think. The PR is merged and the duplicates #1408 and #1455 are also already closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Issues that need to be triaged bug feature: acl Items related to the groupfolders ACL or "Advanced Permissions" feature: caching Items related to caching integration
Projects
None yet
Development

No branches or pull requests

5 participants