Fixed searching for groups in the sharing sideview #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The result of FolderManager::getGroups and ::searchGroups are indexed arrays. Thus, the data returned by the .../search?... route are JSON Objects and not array. Signed-off-by: Jan Niklas Grieb (home) <jan.grieb@gmail.com>
…xtcloud#633 nextcloud#1096 Filter for any non-existing group reference before returning GID and displayname. This enables to continue editing the ACLs despite outdated group references in the groupfolder's permissions. Signed-off-by: Jan Niklas Grieb (home) <jan.grieb@gmail.com>
This was referenced Mar 27, 2021
|
I added a second commit that avoids calling getGID() on null when searching for available groups, referring to issues #633 and #1096 . This other fix is in the backend and filters for any non-existing group reference before returning GID and displayname. This enables to continue editing the ACLs despite outdated group references in the groupfolder's permissions. If desirable, I could also split the frontend and backend fixes into two PRs. |
icewind1991
approved these changes
Apr 1, 2021
juliushaertl
approved these changes
Apr 9, 2021
|
/backport to stable21 |
|
/backport to stable20 |
|
/backport to stable19 |
This was referenced Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result of FolderManager::getGroups and ::searchGroups are indexed
arrays. Thus, the data returned by the .../search?... route
are JSON Objects and not arrays.