Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ListCommand: update for Symfony >=5 exit status #1102

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards added bug Something isn't working 3. to review Waiting for reviews labels Jan 17, 2024
@joshtrichards
Copy link
Member Author

Lint failure is due to this repo not pinning the PHP version whereas we pin it to v8.1 in server:

php-version: ${{ steps.versions.outputs.php-max }}

https://github.com/nextcloud/server/blob/36e0b027121e05070e71a06752f4e942d2b72217/.github/workflows/lint-php-cs.yml#L53

Using PHP 8.3 with php-cs-fixer v3.22 won't work since v3.40.0 looks to be the first release with official PHP 8.3 support:

 php-cs-fixer fix --dry-run --diff
PHP needs to be a minimum version of PHP 7.4.0 and maximum version of PHP 8.2.*.
Current PHP version: 8.3.2.

https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/releases/tag/v3.40.0

@nickvergessen
Copy link
Member

Lint failure is unrelated, but it's not a problem of the action, but the used cs-fixer version needs a bump.

Dependabot PR is not coming as there are too many open

Copy link

github-actions bot commented Feb 1, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Fixes #1101

Return types required in Symfony >=5

Signed-off-by: Josh <josh.t.richards@gmail.com>
@icewind1991 icewind1991 merged commit 4f0bdfc into master Feb 5, 2024
40 checks passed
@icewind1991 icewind1991 deleted the fix/i1101 branch February 5, 2024 14:52
@skjnldsv skjnldsv mentioned this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

occ guests:list execute return type exception
3 participants