Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add talk integration #892

Merged
merged 2 commits into from Jun 3, 2022
Merged

Add talk integration #892

merged 2 commits into from Jun 3, 2022

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented May 20, 2022 •
edited

@nickvergessen nickvergessen added enhancement New feature or request integration Compatibility with other apps/systems 3. to review Waiting for reviews labels May 20, 2022
@nickvergessen nickvergessen marked this pull request as draft May 20, 2022 12:35
@nickvergessen nickvergessen force-pushed the feature/noid/talk-integration branch from d96c0ac to c86943e Compare May 20, 2022 12:54
@nickvergessen nickvergessen mentioned this pull request May 20, 2022
Merged
1 task
PVince81
PVince81 approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine

@nickvergessen
Add talk integration
9760e04 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Add todo for techdebt
f88a99f 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the feature/noid/talk-integration branch from c86943e to f88a99f Compare May 27, 2022 11:53
@nickvergessen nickvergessen marked this pull request as ready for review May 27, 2022 11:53
@nickvergessen nickvergessen merged commit e8172fa into master Jun 3, 2022
@nickvergessen nickvergessen deleted the feature/noid/talk-integration branch June 3, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request integration Compatibility with other apps/systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nickvergessen @PVince81