Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guests app integration #7399

Merged
merged 5 commits into from
May 27, 2022
Merged

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented May 20, 2022

Bildschirmfoto vom 2022-05-20 14-43-10

After the Talk bit is merged we can merge:

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine.

I'm just a bit confused that a PR called "Guest integration" doesn't contain the word "guest" anywhere

Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
@marcoambrosini marcoambrosini force-pushed the feature/noid/guests-app-integration branch from e72a5de to ca65647 Compare May 26, 2022 11:46
<ul>
<Button v-for="(integration, index) in integrations"
:key="'integration' + index"
type="tertiary-no-background"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have prefered the avatar style with the circle permanently around it.
But good enough for now

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

Ready to merge @marcoambrosini ?

@nickvergessen nickvergessen merged commit 8dc924e into master May 27, 2022
@nickvergessen nickvergessen deleted the feature/noid/guests-app-integration branch May 27, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement feature: integration 📦 Integration with 3rd party (chat) service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants