-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guests app integration #7399
Guests app integration #7399
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
...components/RightSidebar/Participants/ParticipantsSearchResults/ParticipantsSearchResults.vue
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine.
I'm just a bit confused that a PR called "Guest integration" doesn't contain the word "guest" anywhere
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
e72a5de
to
ca65647
Compare
<ul> | ||
<Button v-for="(integration, index) in integrations" | ||
:key="'integration' + index" | ||
type="tertiary-no-background" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have prefered the avatar style with the circle permanently around it.
But good enough for now
Ready to merge @marcoambrosini ? |
After the Talk bit is merged we can merge: