fix dashboard api for clients

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
nextcloud · Oct 13, 2022 · 2ebf398 · 2ebf398
1 parent f13cadf
commit 2ebf398
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,7 +6,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
 
-## 1.0.10 – 2022-10-13
+## 1.0.11 – 2022-10-13
 ### Changed
 - use @nextcloud/vue v7.0.0
 - improve reference widget wrapping

diff --git a/appinfo/info.xml b/appinfo/info.xml
@@ -6,7 +6,7 @@
     <description><![CDATA[GitHub integration provides a dashboard widget displaying your most important notifications
     and a unified search provider for repositories, issues and pull requests. It also provides a link reference provider
     to render links to issues, pull requests and comments in Talk and Text.]]></description>
-    <version>1.0.10</version>
+    <version>1.0.11</version>
     <licence>agpl</licence>
     <author>Julien Veyssier</author>
     <namespace>Github</namespace>

diff --git a/lib/Dashboard/GithubWidget.php b/lib/Dashboard/GithubWidget.php
@@ -145,6 +145,9 @@ public function load(): void {
 	 */
 	public function getItems(string $userId, ?string $since = null, int $limit = 7): array {
 		$notifications = $this->githubAPIService->getNotifications($this->userId, null, $since, $limit);
+		if (isset($notifications['error'])) {
+			return [];
+		}
 		$that = $this;
 		return array_map(static function(array $notification) use ($that) {
 			return $that->githubAPIService->getWidgetFromNotification($notification);

diff --git a/lib/Service/GithubAPIService.php b/lib/Service/GithubAPIService.php
@@ -134,7 +134,7 @@ private function getItemIconUrl(array $notification): string {
 			? ''
 			: $this->urlGenerator->getAbsoluteURL(
 				$this->urlGenerator->linkToRoute(Application::APP_ID . '.githubAPI.getAvatar', [
-					'githubUserName' => $repoOwnerLogin,
+					'githubLogin' => $repoOwnerLogin,
 				])
 			);
 	}