refactor tests

Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com>
nextcloud · Jan 11, 2024 · 0168438 · 0168438
1 parent 5f219b6
commit 0168438
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/lib/Controller/FilesController.php b/lib/Controller/FilesController.php
@@ -151,7 +151,9 @@ private function compileFileInfo($fileId) {
 
 		$userFolder = $this->rootFolder->getUserFolder($this->user->getUID());
 		$files = $userFolder->getById($fileId);
-		$file = $files[0];
+		if (is_array($files) && count($files) > 0) {
+			$file = $files[0];
+		}
 		$mounts = $this->mountCollection->getMountCache()->getMountsForFileId($fileId);
 
 		if ($file !== null && is_array($mounts) && count($mounts) > 0) {

diff --git a/tests/lib/Controller/FilesControllerTest.php b/tests/lib/Controller/FilesControllerTest.php
@@ -204,8 +204,7 @@ public function testGetFilesInfoFourIdsRequestedOneExistsOneInTrashOneNotExisiti
 			->willReturnOnConsecutiveCalls(
 				'files/logo.png',
 				'files_trashbin/files/welcome.txt.d1648724302',
-				[],
-				[]
+				'/anotherUser/files/logo.png'
 			);
 
 		$ownerMock = $this->getMockBuilder('\OCP\IUser')->getMock();
@@ -876,7 +875,6 @@ private function createFilesController(
 	 * @param array<string> $onlyMethods
 	 * @param MockObject $folderMock
 	 * @param MockObject|null $mountCacheMock mock for Files that exist but cannot be accessed by this user
-	 * @param bool $isAppEnabled
 	 * @param MockObject|null $davUtilsMock
 	 * @return FilesController|MockObject
 	 */
@@ -916,7 +914,6 @@ public function getFilesControllerMock(
 					$userSessionMock,
 					$mountProviderCollectionMock,
 					$this->createMock(IManager::class),
-					$appManagerMock,
 					$this->createMock(IDBConnection::class),
 					$this->createMock(ILogger::class),
 					$this->createMock(IUserManager::class),