test OAuth requests using pact.io as mock server OP#40804 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
individual-it
requested review from
wielinde,
phil-davis,
julien-nc and
kiranparajuli589
individual-it
force-pushed
the
pactTests
branch
2 times, most recently
from
01e669f
to
7cf6be3
Compare
|
Hi everybody, I am not familiar with the PHP toolchain etc. So I cannot be of great help here. At OP we use similar stuff, for instance Puffing Billy, which allows for mocking services on the browser level. It definitely has its legitimacy. Needless to say, that it will not save us from:
|
| $consumerRequest = new ConsumerRequest(); | ||
| $consumerRequest | ||
| ->setMethod('GET') | ||
| ->setPath('/api/v3/work_packages') |
There was a problem hiding this comment.
using a variable for this path will be useful since it is used multiple times below.
There was a problem hiding this comment.
done, moved the path and also the URL of the mock-server into a variable, please review again
julien-nc
approved these changes
Jan 26, 2022
Signed-off-by: Artur Neumann <artur@jankaritech.com>
individual-it
force-pushed
the
pactTests
branch
from
7cf6be3
to
c802bb3
Compare
individual-it
force-pushed
the
pactTests
branch
from
c802bb3
to
096dda1
Compare
kiranparajuli589
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using the framework of pact.io to mock the OAuth requests of OpenProject and testing the
requestfunctionI'm open for discussion if that is the framework we want to use to mock the requests. The advantage is that, we can simulate real requests and responses without having to spin up a complete NC or OpenProject server.
The framework writes the requests and response into a JSON file and in future we can use that to verify that what we expect from OpenProject is really what they send.
here a short intro in how it works: https://docs.pact.io/getting_started/how_pact_works#consumer-testing