Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unit tests for ConfigController::oauthRedirect #28

Merged
merged 2 commits into from
Jan 29, 2022
Merged

unit tests for ConfigController::oauthRedirect #28

merged 2 commits into from
Jan 29, 2022

Conversation

individual-it
Copy link
Collaborator

  • basic unit tests for ConfigController::oauthRedirect()
  • improve checks and error reporting in that function, so that missing data does not cause undefined index errors

@individual-it
unit tests for ConfigController::oauthRedirect
0a92770 
Signed-off-by: Artur Neumann <artur@jankaritech.com>
@individual-it
improve error reporting
2df119d 
Signed-off-by: Artur Neumann <artur@jankaritech.com>
@individual-it individual-it self-assigned this Jan 28, 2022
@individual-it individual-it merged commit aadaf35 into master Jan 29, 2022
@delete-merged-branch delete-merged-branch bot deleted the tests/ConfigController/oauthRedirect branch January 29, 2022 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 approved these changes

@julien-nc julien-nc Awaiting requested review from julien-nc

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees

@individual-it individual-it

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@individual-it @kiranparajuli589