-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OP#48106] use same component as project tab for searching in smart picker #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> reuse Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> emit event Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> add op icon vue Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com>
97b162a
to
3906597
Compare
Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com>
Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com>
Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com>
b9552cc
to
e8c209d
Compare
SagarGi
reviewed
Aug 3, 2023
Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com>
JS Code CoverageCoverage after merging fix/use-same-component-for-picker into release/2.4 will be
Coverage Report
|
SagarGi
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
SwikritiT
added a commit
that referenced
this pull request
Aug 18, 2023
…icker (#448) * reuse component Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> reuse Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> emit event Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> add op icon vue Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * fix failing tests Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * check for access token Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * add unit test Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * address review Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> --------- Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com>
SwikritiT
added a commit
that referenced
this pull request
Aug 21, 2023
…icker (#448) * reuse component Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> reuse Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> emit event Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> add op icon vue Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * fix failing tests Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * check for access token Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * add unit test Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * address review Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> --------- Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com>
SwikritiT
added a commit
that referenced
this pull request
Aug 21, 2023
* [OP#48106] use same component as project tab for searching in smart picker (#448) * reuse component Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> reuse Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> emit event Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> add op icon vue Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * fix failing tests Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * check for access token Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * add unit test Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * address review Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> --------- Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * Fix the lable of managed project folder (#452) Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * [OP#49182] Fix the form heading index colour in different themes (#453) * Fix the colour of the indexes in different themes Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * update snapshots Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * fix style lint Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> --------- Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * [OP#49621] fix app password form becomes inactive (#456) * Check and remove the app password with name OpenProject Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * add phpunit test Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * add api test to cover the bug Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * add unit test for multiple token Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * add unit test for delete token Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> --------- Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * [OP#49435] Nextcloud oauth section should not be disabled when the user deletes the oauth credentials (#457) * [#49435] Nextcloud oauth section should not be disabled when the user deletes the oauth credentials https://community.openproject.org/work_packages/49435 Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * fix project folder form Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * fix and add unit tests Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * fix the feature Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> --------- Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * Fix link previewd Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * fix link on front end and fix test Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * fix failing php unit test and add more patterns' Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * add php test Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * ignore path Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * Support global work package URL without split view Signed-off-by: Wieland Lindenthal <w.lindenthal@forkmerge.com> --------- Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> Signed-off-by: Wieland Lindenthal <w.lindenthal@forkmerge.com> Co-authored-by: Wieland Lindenthal <w.lindenthal@forkmerge.com>
SwikritiT
added a commit
that referenced
this pull request
Aug 21, 2023
* [OP#48106] use same component as project tab for searching in smart picker (#448) * reuse component Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> reuse Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> emit event Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> add op icon vue Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * fix failing tests Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * check for access token Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * add unit test Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * address review Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> --------- Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * Fix the lable of managed project folder (#452) Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * [OP#49182] Fix the form heading index colour in different themes (#453) * Fix the colour of the indexes in different themes Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * update snapshots Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * fix style lint Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> --------- Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * [OP#49621] fix app password form becomes inactive (#456) * Check and remove the app password with name OpenProject Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * add phpunit test Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * add api test to cover the bug Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * add unit test for multiple token Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * add unit test for delete token Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> --------- Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * [OP#49435] Nextcloud oauth section should not be disabled when the user deletes the oauth credentials (#457) * [#49435] Nextcloud oauth section should not be disabled when the user deletes the oauth credentials https://community.openproject.org/work_packages/49435 Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * fix project folder form Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * fix and add unit tests Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * fix the feature Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> --------- Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * Fix link previewd Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * fix link on front end and fix test Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * fix failing php unit test and add more patterns' Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * add php test Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * ignore path Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * Support global work package URL without split view Signed-off-by: Wieland Lindenthal <w.lindenthal@forkmerge.com> --------- Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> Signed-off-by: Wieland Lindenthal <w.lindenthal@forkmerge.com> Co-authored-by: Wieland Lindenthal <w.lindenthal@forkmerge.com>
SwikritiT
added a commit
that referenced
this pull request
Aug 21, 2023
…icker (#448) * reuse component Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> reuse Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> emit event Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> add op icon vue Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * fix failing tests Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * check for access token Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * add unit test Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * address review Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> --------- Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com>
SwikritiT
added a commit
that referenced
this pull request
Aug 21, 2023
…icker (#448) * reuse component Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> reuse Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> emit event Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> add op icon vue Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * fix failing tests Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * check for access token Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * add unit test Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> * address review Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com> --------- Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we used the default search provider for the smart picker but we this PR we define the custom smart picker so that the search is similar to the one we have implemented in the project tab.
Demonstration
smartPickerNC-.2.mp4