Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OP#40534 delete anything to do with API tokens #46

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

individual-it
Copy link
Collaborator

@individual-it individual-it commented Feb 16, 2022

delete all code that has to do with api key based auth

@individual-it individual-it force-pushed the deleteAPItokens branch 3 times, most recently from 69bf803 to 567f8ca Compare February 21, 2022 05:57
Signed-off-by: Artur Neumann <artur@jankaritech.com>
@github-actions
Copy link

JS Code Coverage

Coverage after merging deleteAPItokens into master will be
31.15%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/components
   AdminSettings.vue0%100%0%0%101, 48–54, 66, 82–84, 88, 95–96, 98
   OAuthConnectButton.vue100%100%100%100%
   PersonalSettings.vue33.33%26.32%27.27%38.89%102–103, 103, 103, 106–107, 107, 107, 110–111, 111, 111, 114, 117–118, 120–121, 121–123, 123, 123, 123–124, 129–130, 130, 130, 135, 141, 89–92, 98–99
src/components/settings
   SettingsTitle.vue0%100%0%0%14
src/components/tab
   EmptyContent.vue100%100%100%100%
   SearchInput.vue30.61%25%45.45%30.16%100, 100, 100, 100–102, 110–112, 115–117, 120–122, 122, 122–124, 124, 124–125, 128, 131, 138, 138, 138–140, 140, 140–141, 143, 148, 148, 148, 153–162, 162–163, 178–182, 182–184, 186–187, 190, 192, 93, 99
src/views
   Dashboard.vue0%0%0%0%101, 106, 106, 106–107, 109, 115, 119–120, 128, 131, 135–137, 139, 142–143, 146–147, 147–148, 152–153, 153–154, 156, 158–159, 159, 159, 159, 159–161, 161, 161, 161, 161–163, 166, 171, 171, 171, 173–174, 174, 174–175, 177, 177–179, 183, 187, 190, 190, 190, 193, 193, 193, 198, 201, 201, 201, 208, 211, 211, 211, 216, 216, 216, 22, 221, 221, 221, 226, 229, 23, 232, 235, 235, 235, 238, 238, 238, 24, 241, 244, 247, 25–30, 47, 54, 54, 61, 64–65, 77–78, 78, 78, 81, 84, 84, 84–86, 86, 86–88, 88–89, 91, 94, 94, 94–96, 96, 96–98, 98–99
   ProjectsTab.vue90.91%100%83.33%90.48%74–75

@github-actions
Copy link

PHP Code Coverage

Coverage after merging deleteAPItokens into master will be
43.56%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
lib/AppInfo
   Application.php0%100%0%0%101, 105, 49, 51–52, 54–56, 59–60, 63–65, 67, 70–71, 74–77, 79–84, 86, 88, 91, 95, 99
lib/BackgroundJob
   CheckNotifications.php0%100%0%0%48, 50, 52–53, 61–62
lib/Controller
   ConfigController.php60.71%100%60%60.76%105–106, 108, 184–189, 191–194, 196, 198, 71–72, 74, 76–78, 80–85, 87, 91–92, 94
   OpenProjectAPIController.php96.43%100%85.71%97.96%77
lib/Dashboard
   OpenProjectWidget.php0%100%0%0%106–109, 61–64, 71, 78, 85, 92, 99
lib/Listener
   LoadSidebarScript.php0%100%0%0%59–61, 65–66, 68, 70, 72–74, 76–78
lib/Notification
   Notifier.php0%100%0%0%100, 110, 112, 114, 47–50, 60, 69, 80, 82, 85, 87–92
lib/Search
   OpenProjectSearchProvider.php0%100%0%0%102, 109–110, 113–116, 118–119, 123, 127–131, 133–135, 138–139, 141–142, 146–147, 157, 169, 177, 180, 183, 192, 195, 206, 71–75, 82, 89, 97, 99
   OpenProjectSearchResultEntry.php100%100%100%100%
lib/Service
   OpenProjectAPIService.php58.80%100%66.67%58.21%105–114, 116–120, 122–127, 129–130, 133–136, 143, 150–154, 164–165, 167–171, 173–174, 182–186, 365–366, 368, 374, 380–385, 387, 393, 421–424, 427–428, 430, 432–433, 455–456, 463, 466–469, 471, 477, 481–483, 95–98
lib/Settings
   Admin.php0%100%0%0%25–26, 33–35, 37, 42–43, 47, 51
   AdminSection.php0%100%0%0%19–20, 29, 39, 48, 55
   Personal.php0%100%0%0%38–41, 48–52, 55, 57, 65–66, 70, 74
   PersonalSection.php0%100%0%0%19–20, 29, 39, 48, 55

@individual-it individual-it changed the title delete anything to do with API tokens OP#40534 delete anything to do with API tokens Feb 22, 2022
@individual-it individual-it marked this pull request as ready for review February 22, 2022 06:16
@individual-it individual-it self-assigned this Feb 22, 2022
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@individual-it individual-it merged commit 09f55d4 into master Feb 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the deleteAPItokens branch February 22, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants