Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

construct filters from array #48

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Conversation

individual-it
Copy link
Collaborator

this will make it simpler to extend the filter, e.g. when we want also to filter by file_link_origin_id to list all workpackages associated to the file

Signed-off-by: Artur Neumann <artur@jankaritech.com>
@github-actions
Copy link

JS Code Coverage

Coverage after merging constructFiltersFromArray into master will be
26.09%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   utils.js8.33%0%0%14.29%3–9, 9
src/components
   AdminSettings.vue0%100%0%0%101, 48–54, 66, 82–84, 88, 95–96, 98
   PersonalSettings.vue24.76%15.15%26.32%30.19%126, 126, 126, 126, 126, 137–140, 146–147, 150–151, 151, 151, 154–155, 155, 155, 158–159, 159, 159, 162–164, 164, 164, 164–165, 167–168, 168, 168–169, 172, 172, 175, 178, 178, 184, 187–188, 190–191, 191–193, 193, 193, 193–194, 199–200, 200, 200, 205, 211, 215–216, 222, 228–229, 231, 234
src/components/settings
   SettingsTitle.vue0%100%0%0%14
src/components/tab
   EmptyContent.vue100%100%100%100%
   SearchInput.vue30.61%25%45.45%30.16%100, 100, 100, 100–102, 110–112, 115–117, 120–122, 122, 122–124, 124, 124–125, 128, 131, 138, 138, 138–140, 140, 140–141, 143, 148, 148, 148, 153–162, 162–163, 178–182, 182–184, 186–187, 190, 192, 93, 99
src/views
   Dashboard.vue0%0%0%0%100, 106, 106, 106–107, 109, 115, 119–120, 128, 131, 135–137, 139, 142–143, 146–147, 147–148, 152–153, 153–154, 156, 158–159, 159, 159, 159, 159–161, 161, 161, 161, 161–163, 166, 171, 171, 171, 173–174, 174, 174–175, 177, 177–179, 183, 187, 190, 190, 190, 193, 193, 193, 198, 201, 201, 201, 208, 211, 211, 211, 216, 216, 216, 221, 221, 221, 226, 229, 232, 235, 235, 235, 238, 238, 238, 24, 241, 244, 247, 25–30, 47, 53, 53, 60, 63–64, 76–77, 77, 77, 80, 83, 83, 83–85, 85, 85–87, 87–88, 90, 93, 93, 93–95, 95, 95–97, 97–98
   ProjectsTab.vue90.63%100%83.33%90%69–70

@github-actions
Copy link

PHP Code Coverage

Coverage after merging constructFiltersFromArray into master will be
45.45%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
lib/AppInfo
   Application.php0%100%0%0%101, 105, 49, 51–52, 54–56, 59–60, 63–65, 67, 70–71, 74–77, 79–84, 86, 88, 91, 95, 99
lib/BackgroundJob
   CheckNotifications.php0%100%0%0%48, 50, 52–53, 61–62
lib/Controller
   ConfigController.php66.67%100%60%67.07%106–107, 109, 184, 194–197, 199, 201, 71–72, 74, 76–78, 80–87, 92–93, 95
   OpenProjectAPIController.php96.49%100%85.71%98%82
lib/Dashboard
   OpenProjectWidget.php0%100%0%0%44–45, 52, 59, 66, 73, 80, 87–88
lib/Listener
   LoadSidebarScript.php0%100%0%0%37–38, 40, 42, 44–46, 48
lib/Notification
   Notifier.php0%100%0%0%100, 110, 112, 114, 47–50, 60, 69, 80, 82, 85, 87–92
lib/Search
   OpenProjectSearchProvider.php0%100%0%0%102, 109–110, 113–116, 118–119, 123, 127–132, 134–136, 139–140, 142–143, 147–148, 158, 170, 178, 181, 184, 193, 196, 207, 71–75, 82, 89, 97, 99
   OpenProjectSearchResultEntry.php100%100%100%100%
lib/Service
   OpenProjectAPIService.php58.56%100%64.29%58.17%104–114, 116–120, 122–127, 129–130, 133–136, 143, 150–154, 164–165, 167–171, 173–174, 182–186, 317, 360, 375–376, 378, 384, 390–395, 397, 403, 431–434, 437–438, 440, 442–443, 465–466, 473, 476–479, 481, 487, 491–493, 94–97
lib/Settings
   Admin.php0%100%0%0%25–26, 33–35, 37, 42–43, 47, 51
   AdminSection.php0%100%0%0%19–20, 29, 39, 48, 55
   Personal.php0%100%0%0%31–33, 40–46, 49, 51–52, 54, 66–67, 71, 75
   PersonalSection.php0%100%0%0%19–20, 29, 39, 48, 55

Copy link
Collaborator

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@individual-it individual-it merged commit 0918ff1 into master Feb 17, 2022
@delete-merged-branch delete-merged-branch bot deleted the constructFiltersFromArray branch February 17, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants