-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WP#50814]Look up for to migrate to new files action register #515
Conversation
I pushed a commit that changes the event listening to load the script (that was not loaded before). |
d2f2625
to
aad22c7
Compare
Just in case: To set a different action name on the single and multiple menu entry: https://github.com/nextcloud/integration_mattermost/blob/main/src/filesplugin.js#L56-L60 |
We need to find the condition for what the user has selected the file through may be. (context menu or the batch action) |
27b55f0
to
80e3019
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs some more adjustments. Requesting changes to prevent accidental merging
eb267f4
to
98035cd
Compare
The UI looks as expected and linking is also working |
98035cd
to
35106b5
Compare
eb44efe
to
f54df9a
Compare
Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>
f54df9a
to
da5c1f6
Compare
JS Code CoverageCoverage after merging try_out_files_actions into master will be
Coverage Report
|
Description
The files action for the integration app for the new version
NC-28
or greater is registered in a style different from older versions. So a separate script is needed to be loaded for it.Relates WP:
https://community.openproject.org/projects/nextcloud-integration/work_packages/50814
https://community.openproject.org/projects/nextcloud-integration/work_packages/50608