-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CI run with stable28 #521
Conversation
Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com>
Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com>
@@ -56,7 +56,7 @@ jobs: | |||
sudo apt install make openssl -y | |||
echo "###### installing nextcloud" | |||
mkdir ~/html | |||
git clone https://github.com/nextcloud/server.git --recursive --depth 1 -b master ~/html/nextcloud | |||
git clone https://github.com/nextcloud/server.git --recursive --depth 1 -b stable28 ~/html/nextcloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've also updated release workflow to use stable28
, I can revert this if we will support 29 for our upcoming release of this app
JS Code CoverageCoverage after merging update-master-to-stable28 into master will be
Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good!
@SagarGi please create an follow-up WP, so that we don't forget to go back to master
Nextcloud checked out a stable-28 branch https://github.com/nextcloud/server/tree/stable28 so now the master is version-29 , since apps like
groupfolders
aren't yet compatible with nextcloud version-29 we are getting CI failures likeThis will unblock the CI.
Related Workpackage
OP#51218 - https://community.openproject.org/projects/nextcloud-integration/work_packages/51218