-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OP#41124] Display loading icon while fetching workpackages #55
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,203 @@ | ||
| [{ | ||
| "derivedStartDate": "2022-01-15", | ||
| "derivedDueDate": "2022-03-08", | ||
| "_type": "WorkPackage", | ||
| "id": 2, | ||
| "lockVersion": 0, | ||
| "subject": "Organize open source conference", | ||
| "description": { | ||
| "format": "markdown", | ||
| "raw": null, | ||
| "html": "" | ||
| }, | ||
| "scheduleManually": false, | ||
| "startDate": "2022-01-15", | ||
| "dueDate": "2022-03-26", | ||
| "estimatedTime": null, | ||
| "derivedEstimatedTime": null, | ||
| "percentageDone": 0, | ||
| "createdAt": "2022-01-12T08:53:29Z", | ||
| "updatedAt": "2022-01-12T08:53:29Z", | ||
| "_links": { | ||
| "attachments": { | ||
| "href": "/api/v3/work_packages/2/attachments" | ||
| }, | ||
| "addAttachment": { | ||
| "href": "/api/v3/work_packages/2/attachments", | ||
| "method": "post" | ||
| }, | ||
| "self": { | ||
| "href": "/api/v3/work_packages/2", | ||
| "title": "Organize open source conference" | ||
| }, | ||
| "update": { | ||
| "href": "/api/v3/work_packages/2/form", | ||
| "method": "post" | ||
| }, | ||
| "schema": { | ||
| "href": "/api/v3/work_packages/schemas/1-3" | ||
| }, | ||
| "updateImmediately": { | ||
| "href": "/api/v3/work_packages/2", | ||
| "method": "patch" | ||
| }, | ||
| "delete": { | ||
| "href": "/api/v3/work_packages/2", | ||
| "method": "delete" | ||
| }, | ||
| "move": { | ||
| "href": "/work_packages/2/move/new", | ||
| "type": "text/html", | ||
| "title": "Move Organize open source conference" | ||
| }, | ||
| "copy": { | ||
| "href": "/work_packages/2/copy", | ||
| "title": "Copy Organize open source conference" | ||
| }, | ||
| "pdf": { | ||
| "href": "/work_packages/2.pdf", | ||
| "type": "application/pdf", | ||
| "title": "Export as PDF" | ||
| }, | ||
| "atom": { | ||
| "href": "/work_packages/2.atom", | ||
| "type": "application/rss+xml", | ||
| "title": "Atom feed" | ||
| }, | ||
| "availableRelationCandidates": { | ||
| "href": "/api/v3/work_packages/2/available_relation_candidates", | ||
| "title": "Potential work packages to relate to" | ||
| }, | ||
| "customFields": { | ||
| "href": "/projects/demo-project/settings/custom_fields", | ||
| "type": "text/html", | ||
| "title": "Custom fields" | ||
| }, | ||
| "configureForm": { | ||
| "href": "/types/3/edit?tab=form_configuration", | ||
| "type": "text/html", | ||
| "title": "Configure form" | ||
| }, | ||
| "activities": { | ||
| "href": "/api/v3/work_packages/2/activities" | ||
| }, | ||
| "availableWatchers": { | ||
| "href": "/api/v3/work_packages/2/available_watchers" | ||
| }, | ||
| "relations": { | ||
| "href": "/api/v3/work_packages/2/relations" | ||
| }, | ||
| "revisions": { | ||
| "href": "/api/v3/work_packages/2/revisions" | ||
| }, | ||
| "watchers": { | ||
| "href": "/api/v3/work_packages/2/watchers" | ||
| }, | ||
| "addWatcher": { | ||
| "href": "/api/v3/work_packages/2/watchers", | ||
| "method": "post", | ||
| "payload": { | ||
| "user": { | ||
| "href": "/api/v3/users/{user_id}" | ||
| } | ||
| }, | ||
| "templated": true | ||
| }, | ||
| "removeWatcher": { | ||
| "href": "/api/v3/work_packages/2/watchers/{user_id}", | ||
| "method": "delete", | ||
| "templated": true | ||
| }, | ||
| "addRelation": { | ||
| "href": "/api/v3/work_packages/2/relations", | ||
| "method": "post", | ||
| "title": "Add relation" | ||
| }, | ||
| "addChild": { | ||
| "href": "/api/v3/projects/demo-project/work_packages", | ||
| "method": "post", | ||
| "title": "Add child of Organize open source conference" | ||
| }, | ||
| "changeParent": { | ||
| "href": "/api/v3/work_packages/2", | ||
| "method": "patch", | ||
| "title": "Change parent of Organize open source conference" | ||
| }, | ||
| "addComment": { | ||
| "href": "/api/v3/work_packages/2/activities", | ||
| "method": "post", | ||
| "title": "Add comment" | ||
| }, | ||
| "previewMarkup": { | ||
| "href": "/api/v3/render/markdown?context=/api/v3/work_packages/2", | ||
| "method": "post" | ||
| }, | ||
| "category": { | ||
| "href": null | ||
| }, | ||
| "type": { | ||
| "href": "/api/v3/types/3", | ||
| "title": "Phase" | ||
| }, | ||
| "priority": { | ||
| "href": "/api/v3/priorities/8", | ||
| "title": "Normal" | ||
| }, | ||
| "project": { | ||
| "href": "/api/v3/projects/1", | ||
| "title": "Demo project" | ||
| }, | ||
| "status": { | ||
| "href": "/api/v3/statuses/7", | ||
| "title": "In progress" | ||
| }, | ||
| "author": { | ||
| "href": "/api/v3/users/1" | ||
| }, | ||
| "responsible": { | ||
| "href": null | ||
| }, | ||
| "assignee": { | ||
| "href": "/api/v3/users/1", | ||
| "title": "System" | ||
| }, | ||
| "version": { | ||
| "href": null | ||
| }, | ||
| "github_pull_requests": { | ||
| "href": "/api/v3/work_packages/2/github_pull_requests", | ||
| "title": "GitHub pull requests" | ||
| }, | ||
| "watch": { | ||
| "href": "/api/v3/work_packages/2/watchers", | ||
| "method": "post", | ||
| "payload": { | ||
| "user": { | ||
| "href": "/api/v3/users/3" | ||
| } | ||
| } | ||
| }, | ||
| "children": [ | ||
| { | ||
| "href": "/api/v3/work_packages/3", | ||
| "title": "Set date and location of conference" | ||
| }, | ||
| { | ||
| "href": "/api/v3/work_packages/4", | ||
| "title": "Setup conference website" | ||
| }, | ||
| { | ||
| "href": "/api/v3/work_packages/5", | ||
| "title": "Invite attendees to conference" | ||
| } | ||
| ], | ||
| "ancestors": [], | ||
| "parent": { | ||
| "href": null, | ||
| "title": null | ||
| }, | ||
| "customActions": [] | ||
| } | ||
| } | ||
|
|
||
| ] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
datais also redundant here imoThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it gives me the error
TypeError: Cannot read property 'color' of undefined, if I don't define dataThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be done in an other PR, but I would suggest to improve
getWorkPackageColorAttributesit checks
if (response.status === 200) {and the assumes that the response has a color attribute, but what if not?Should be something like
if (response.status === 200 && response.data.color !== undefined) {