-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change url for groupfolder apps on admin tab #581
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d641673
to
34f3107
Compare
SagarGi
requested changes
Mar 4, 2024
34f3107
to
a5a02a0
Compare
a5a02a0
to
beb3ada
Compare
SagarGi
reviewed
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
beb3ada
to
4acc613
Compare
4acc613
to
3312ca7
Compare
SagarGi
reviewed
Mar 11, 2024
3312ca7
to
f797290
Compare
SagarGi
requested changes
Mar 11, 2024
f797290
to
402b1f7
Compare
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
402b1f7
to
2cec8ea
Compare
JS Code CoverageCoverage after merging change-url-for-groupfolder into master will be
Coverage Report |
SagarGi
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
nabim777
added a commit
that referenced
this pull request
Mar 13, 2024
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
8 tasks
SagarGi
pushed a commit
that referenced
this pull request
Mar 13, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously in PR-579 the group folder url was https://apps.nextcloud.com/apps/groupfolders
![image](https://private-user-images.githubusercontent.com/61624650/309685051-619a6a6b-bbc5-494e-84b7-1d000b5147d7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA5ODYzNjksIm5iZiI6MTcyMDk4NjA2OSwicGF0aCI6Ii82MTYyNDY1MC8zMDk2ODUwNTEtNjE5YTZhNmItYmJjNS00OTRlLTg0YjctMWQwMDBiNTE0N2Q3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE0VDE5NDEwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZjNzczMGI2M2IzYzMzYTk4YzA2OTA2ZjZkZjYwZjNlZGUwOWUxNGZmODhhM2Y3YmMxNTY4ZWVlZjhkMmU1NjUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0._d_i4wdBAx8O9sI-NUM65OgzRC7H2eYmjYFLBXm4i9M)
and Now in this PR the group folder URL is change which redirect to settings/apps/groupfolder
Related issue
https://community.openproject.org/projects/nextcloud-integration/work_packages/52987/activity
Screenshot
Types of changes
Checklist:
CHANGELOG.md
file