Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate redirect_uri and don't take it from user config #62

Merged
merged 2 commits into from
Feb 24, 2022

Conversation

individual-it
Copy link
Collaborator

getting it from user config is obsolete since #35 best just generate it here

Signed-off-by: Artur Neumann <artur@jankaritech.com>
Signed-off-by: Kiran Parajuli <kiranparajuli589@gmail.com>
@github-actions
Copy link

JS Code Coverage

Coverage after merging generateRedirectUri into master will be
42.15%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/components
   AdminSettings.vue0%100%0%0%101, 48–54, 66, 82–84, 88, 95–96, 98
   OAuthConnectButton.vue100%100%100%100%
   PersonalSettings.vue33.33%26.32%27.27%38.89%102–103, 103, 103, 106–107, 107, 107, 110–111, 111, 111, 114, 117–118, 120–121, 121–123, 123, 123, 123–124, 129–130, 130, 130, 135, 141, 89–92, 98–99
src/components/settings
   SettingsTitle.vue0%100%0%0%14
src/components/tab
   EmptyContent.vue100%100%100%100%
   SearchInput.vue69.15%45.45%90.91%73.77%100–101, 101, 101, 101–103, 111–113, 116–119, 122–123, 123, 123–125, 125, 125–126, 129, 132, 139–140, 149
src/views
   Dashboard.vue0%0%0%0%101, 106, 106, 106–107, 109, 115, 119–120, 128, 131, 135–137, 139, 142–143, 146–147, 147–148, 152–153, 153–154, 156, 158–159, 159, 159, 159, 159–161, 161, 161, 161, 161–163, 166, 171, 171, 171, 173–174, 174, 174–175, 177, 177–179, 183, 187, 190, 190, 190, 193, 193, 193, 198, 201, 201, 201, 208, 211, 211, 211, 216, 216, 216, 22, 221, 221, 221, 226, 229, 23, 232, 235, 235, 235, 238, 238, 238, 24, 241, 244, 247, 25–30, 47, 54, 54, 61, 64–65, 77–78, 78, 78, 81, 84, 84, 84–86, 86, 86–88, 88–89, 91, 94, 94, 94–96, 96, 96–98, 98–99
   ProjectsTab.vue90.91%100%83.33%90.48%74–75

@github-actions
Copy link

PHP Code Coverage

Coverage after merging generateRedirectUri into master will be
38.70%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
lib/AppInfo
   Application.php0%100%0%0%49, 51–52, 54–55, 59–60, 63, 70, 74–77, 79–84, 95, 99
lib/BackgroundJob
   CheckNotifications.php0%100%0%0%48, 50, 52–53, 61–62
lib/Controller
   ConfigController.php57.33%100%60%57.14%106–107, 109, 187–192, 194–197, 199, 201, 72–73, 75, 77–79, 81–86, 92–93, 95
   OpenProjectAPIController.php96.36%100%85.71%97.92%78
lib/Dashboard
   OpenProjectWidget.php0%100%0%0%106–109, 61–64, 71, 78, 85, 92, 99
lib/Listener
   LoadSidebarScript.php0%100%0%0%59–61, 65–66, 68, 70, 72–74, 76–78
lib/Notification
   Notifier.php0%100%0%0%100–104, 109–110, 112, 114, 47–50, 60, 69, 80, 82, 85, 87–92, 95, 97
lib/Search
   OpenProjectSearchProvider.php0%100%0%0%102, 109–110, 113–116, 118–119, 123–125, 127–131, 133–135, 138–139, 141–142, 146–147, 149–151, 157–158, 160, 169, 177–183, 192–197, 206, 71–75, 82, 89, 97, 99
   OpenProjectSearchResultEntry.php100%100%100%100%
lib/Service
   OpenProjectAPIService.php55.49%100%66.67%54.49%105–114, 116–119, 122–127, 129–130, 133–134, 150–154, 164–165, 167–171, 173, 182–186, 365–366, 368, 374, 380–385, 387, 393, 421–424, 427–428, 430, 432, 455–456, 463, 466–469, 471, 477, 481–483, 95–96
lib/Settings
   Admin.php0%100%0%0%25–26, 33–35, 37, 42–43, 47, 51
   AdminSection.php0%100%0%0%19–20, 29, 39, 48, 55
   Personal.php0%100%0%0%38–41, 48–52, 55, 57, 59–61, 65–66, 70, 74
   PersonalSection.php0%100%0%0%19–20, 29, 39, 48, 55

@kiranparajuli589 kiranparajuli589 merged commit 5bb3462 into master Feb 24, 2022
@delete-merged-branch delete-merged-branch bot deleted the generateRedirectUri branch February 24, 2022 12:12
@individual-it
Copy link
Collaborator Author

Note this was missed in the original PR because I had an redirect_uristill in my DB so all manual tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants