-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor getOpenProjectOauthURL
so that it throws an exception if any needed value is not set
#75
Merged
kiranparajuli589
merged 3 commits into
master
from
throw-exception-from-oauth-redirect-uri-getter
Mar 18, 2022
Merged
refactor getOpenProjectOauthURL
so that it throws an exception if any needed value is not set
#75
kiranparajuli589
merged 3 commits into
master
from
throw-exception-from-oauth-redirect-uri-getter
Mar 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bb0ef4e
to
ffaf7f2
Compare
individual-it
requested changes
Mar 17, 2022
9a8cb22
to
59506c3
Compare
individual-it
approved these changes
Mar 18, 2022
…t ok Signed-off-by: Kiran Parajuli <kiranparajuli589@gmail.com>
Signed-off-by: Parajuli Kiran <kiranparajuli589@gmail.com>
Signed-off-by: Parajuli Kiran <kiranparajuli589@gmail.com>
59506c3
to
8fe4405
Compare
JS Code CoverageCoverage after merging throw-exception-from-oauth-redirect-uri-getter into master will be
Coverage Report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
getOpenProjectOauthURL
if request url is not validScreenshots
Related
OP#41211 > 3rd todo item
https://community.openproject.org/projects/nextcloud-integration/work_packages/41211