-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[op#41470] reset search input state if fileInfo prop has changed #82
Merged
individual-it
merged 2 commits into
master
from
reset-search-input-state-if-fileinfo-changes
Mar 22, 2022
Merged
[op#41470] reset search input state if fileInfo prop has changed #82
individual-it
merged 2 commits into
master
from
reset-search-input-state-if-fileinfo-changes
Mar 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
individual-it
requested changes
Mar 22, 2022
Signed-off-by: Parajuli Kiran <kiranparajuli589@gmail.com>
Signed-off-by: Kiran Parajuli <kiranparajuli589@gmail.com>
a55505e
to
b0ab9b2
Compare
@individual-it I've addressed your reviews. please have a look again. |
JS Code CoverageCoverage after merging reset-search-input-state-if-fileinfo-changes into master will be
Coverage Report |
individual-it
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reset search input state if the
fileInfo
prop changesRelated
OP#41470
Signed-off-by: Parajuli Kiran kiranparajuli589@gmail.com