Do not reorder list when a file has been favourited

[binarykitchen]

Steps to reproduce

1. On your iPhone, open your awesome Nextcloud app
2. Locate some file X at the very bottom of a very long directory in the file browser.
3. Click on the triple point menu "..." on the left and choose “Add to favourites”
4. That file seems like it's gone, not showing up anymore in the file browser
5. But it appears under the favourites tab

Expected behaviour

I expect favourite files to appear in the file browser and under favourites both. Don't have to remove it in the file browser nor alter its sorting logic.

Because not everyone can remember if file X has been "favourite"-ed or not. Keep it in both places pretty please.

Actual behaviour

Once file X has been favourited, it looks like it has disappeared in the file browser and only shows up under the favourites tab which is wrong IMO.

But heck, no, that favourited file still appears on top of that directory against the sorting logic to sort it by A to Z.

Reasoning or why should it be changed/implemented?

A directory should always reflect its files no matter what, in the same sorting logic, not ruling out favourites. Why?

Environment data

iOS version: iOS 15.4.1

Nextcloud iOS app version: 4.3.1.0 ... but actually this doesn't matter. This issue has been bugging me for many months.

....

Happy to discuss anything further. I think this usability issue is a big problem. Thanks for your awesome work. Please give this one issue attention. Peace out.

[thisIsTheFoxe]

Hi, thanks for your report.
Sadly, I wasn't able to reproduce this issue. It's not intended to remove the files from the "Files" tab, once they are favourited. However - mirroring the Nextcloud web UI - they will be re-ordered and show on top of the list (in the same directory). This behaviour is the same for most file views in the app, except for Recent files (in the More tab).
Please check if you can confirm that you don't see your favourited files anywhere else except the Favourites tab (e.g. Recent, Offline files, Shares, when searching in the Files tab)?

[binarykitchen]

Ah @thisIsTheFoxe, you are right, it is shown on top of the list in the same directory!

Before I've favourited that file, it was at the bottom of a long list.

I've clearly set the sorting order by name (from A to Z). Why does it move that file to the top against this sorting logic? Maybe that's a new bug?

Can you change this behaviour to prevent favourite files to be shown on top against sorting logic?

[thisIsTheFoxe]

Ok, thanks for letting us know. In that case could you please update the issue and title?
Also, as I mentioned before this mirrors the server behaviour. So if we were to add a setting for that we should add it there first. See also nextcloud/server#2350

[binarykitchen]

@thisIsTheFoxe done, updated title and issue.

Awesome job of yours for chasing after me with details. Much respect. Ich würde dir jetzt ein Bier spendieren ;)