Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wish list: create a camera qr code to grant access #374

Closed
Spacial opened this issue Sep 15, 2017 · 18 comments
Closed

Wish list: create a camera qr code to grant access #374

Spacial opened this issue Sep 15, 2017 · 18 comments
Milestone

Comments

@Spacial
Copy link

Spacial commented Sep 15, 2017

The main idea is using a qrcode on server (on sync clients), so you dont need to type the app specific password, just point and everything is configured (server, user and otp).

Could even (in qr code) some hash of the server's certificate to guarantee no MITM attack.

@tflidd
Copy link

tflidd commented Oct 28, 2017

ref: nextcloud/server#5659

@ChristophWurst
Copy link
Member

Server ticket: nextcloud/server#429
Server PR: nextcloud/server#429
Android implementation: nextcloud/android#3383

@marinofaggiana any status on this? Is it feasible to integrate a qr code reader into the login screen?

@marinofaggiana
Copy link
Member

@ChristophWurst it is in TODO ... 😨

@marinofaggiana marinofaggiana added this to the v2.23.2 milestone Mar 4, 2019
marinofaggiana added a commit that referenced this issue Mar 5, 2019
@marinofaggiana
Copy link
Member

Available on TestFlight 2.23.2 (Build 3)

19-03-05 10-25-27 2667

2019-03-05 11-04-24-1

@ChristophWurst
Copy link
Member

Awesome!

@AndrStnz
Copy link

AndrStnz commented Mar 5, 2019

It works, with the example provided in the "server Issue # 429" ... so now how do I enable it for my own server 😄

@ChristophWurst
Copy link
Member

Thanks for testing @AndrewwHummer! That's great to hear. You'll have to be patient a bit as we're stabilizing Nextcloud 16 at the moment. It will take a few more weeks before the final release, but you can also check out a beta release once ready: https://github.com/nextcloud/server/wiki/Maintenance-and-Release-Schedule

@AndrStnz
Copy link

AndrStnz commented Mar 5, 2019

Thanks for the information. Will try the beta as soon its ready! :)

@tobiasKaminsky
Copy link
Member

works for me also, but you QR needs to include http/https protocol, otherwise it will fail.

@marinofaggiana
Copy link
Member

marinofaggiana commented Mar 5, 2019

Should be obligatory the protocol in qrcode !? Otherwise I don't know if it's http or https @ChristophWurst

@tobiasKaminsky
Copy link
Member

I just created a qrcode on my own and on android we always first try https if no protocol is specified. It https is not working, we test http and show a warning that it is unsecure.

@tobiasKaminsky
Copy link
Member

Background: It can happen that people generate the qr code on their own, for e.g. easy roll out of clients, etc. and therefore it should be as error prone as possible.

@ChristophWurst
Copy link
Member

is there anything we have to change on the server?

@marinofaggiana
Copy link
Member

marinofaggiana commented Mar 6, 2019

Ok, I add this strange control, but for me the qrcode should have the protocol.

@ChristophWurst
Copy link
Member

If so, please open a ticket in the server repo and let me know about the exact format of the URL. I'm also unsure if we should or have to URL encode any parameter and how that is handled on the mobile apps.

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Mar 6, 2019

is there anything we have to change on the server?

nc://login/user:tobi&password:XJdpw-R9kF3-Liy5C-MjNEZ-aTjSN&server:http://localhost/nc

looks fine.
However I have not tested it with withespaces/@ in userId, but I'll do now.

EDIT: works fine on Android & iOS.

@ChristophWurst
Copy link
Member

Okay, thanks for testing. Just let me know if we have to fix anything on the server-side :)

@marinofaggiana
Copy link
Member

I have add the check whether server: contain protocol. If not add https:// by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants