Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File search #53

Closed
MorrisJobke opened this issue Feb 5, 2017 · 11 comments
Closed

File search #53

MorrisJobke opened this issue Feb 5, 2017 · 11 comments
Milestone

Comments

@MorrisJobke
Copy link
Member

Implement file search which would be similar to what the server frontend does.

The API can be found at nextcloud/server#676 and is basically the same as nextcloud/android#558

@nextcloud/designers How should this look like on iOS. Maybe @jancborchardt and @mario can help here.

Best would be to immediately filter the current view on the search term and then show the search results as they are received from the server. Right, @jancborchardt?

The search results should show a list with

  • name
  • folder name
  • when clicking on it it should directly open this file (just like clicking on it in the file list)
  • long clicking on the file should show "go to folder"

as reference the current web view:

bildschirmfoto 2017-01-11 um 14 52 07

cc @marinofaggiana

@oparoz Anything I forgot?

@disaster123
Copy link

It would be great if it would be possible to work with +,-,"and" and "or" like you can at google.

@MorrisJobke
Copy link
Member Author

It would be great if it would be possible to work with +,-,"and" and "or" like you can at google.

First of all: we do a basic search. Then we can look into refine this.

@jancborchardt
Copy link
Member

Best would be to immediately filter the current view on the search term and then show the search results as they are received from the server. Right, @jancborchardt?

Exactly. That provides the quickest feedback while giving detailed results when they come in. The layout should be exactly the same as the file list itself.

@marinofaggiana
Copy link
Member

marinofaggiana commented Mar 20, 2017

This is the solution for search :

Root "/" folder, two possibilities

  • search in this folder (filter)
  • search in ALL folder (search in all server folders)

1

All subfolder, two possibilities

  • search in this folder (filter)
  • search here and subfolders

2

All possibilities are so fulfilled :)

@MorrisJobke
Copy link
Member Author

It's basically done. I opened bug reports for broken stuff:

#126 & #127

@rakekniven rakekniven added this to the v2.17 milestone Mar 24, 2017
@supportreq
Copy link

@MorrisJobke is this change added to master?? i tried compiling the new version but did not get search here and subfolders option.. please advice.. [Is it server dependent??]

@mario
Copy link
Contributor

mario commented Mar 29, 2017

@supportreq it is server dependant, yes.

@supportreq
Copy link

@mario which server version onwards will it work??

@mario
Copy link
Contributor

mario commented Mar 29, 2017 via email

@supportreq
Copy link

should i pull it from the server master branch?

@mario
Copy link
Contributor

mario commented Mar 29, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants