Collection view common fix + lint Data

[marinofaggiana]

• lint
• fix on NCCollectionViewCommon

[mpivchev]

Can we extract these magic 1s into a variable or a constant?

[mpivchev]

This was not resolved

[mpivchev]

Can you specify in more detail what exactly this is fixing? "fix on NCCollectionViewCommon" doesn't really say much, thanks.

[codecov]

Codecov Report

Patch coverage: 17.93% and project coverage change: +0.34 🎉

Comparison is base (86555bf) 8.88% compared to head (9aa1bd0) 9.23%.

❗ Current head 9aa1bd0 differs from pull request most recent head a6504e9. Consider uploading reports for the commit a6504e9 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           develop   #2512      +/-   ##
==========================================
+ Coverage     8.88%   9.23%   +0.34%     
==========================================
  Files          185     185              
  Lines        25828   26013     +185     
  Branches      9528    9719     +191     
==========================================
+ Hits          2296    2403     +107     
- Misses       23335   23398      +63     
- Partials       197     212      +15     

Impacted Files	Coverage Δ
iOSClient/Data/NCDataSource.swift	11.04% <0.00%> (+0.03%)	⬆️
iOSClient/Data/NCManageDatabase+Activity.swift	5.98% <0.00%> (-1.01%)	⬇️
iOSClient/Data/NCManageDatabase+E2EE.swift	4.42% <0.00%> (-0.53%)	⬇️
iOSClient/Data/NCManageDatabase+Groupfolders.swift	6.66% <0.00%> (ø)
iOSClient/Data/NCManageDatabase+Share.swift	1.69% <0.00%> (-0.27%)	⬇️
...ain/Collection Common/NCCollectionViewCommon.swift	24.41% <0.00%> (+0.53%)	⬆️
...Client/Data/NCManageDatabase+DashboardWidget.swift	11.32% <5.88%> (+4.79%)	⬆️
iOSClient/Data/NCManageDatabase.swift	17.88% <8.79%> (-0.82%)	⬇️
iOSClient/Data/NCManageDatabase+Metadata.swift	20.89% <13.63%> (-2.05%)	⬇️
iOSClient/Data/NCManageDatabase+Video.swift	18.68% <18.18%> (-0.64%)	⬇️
... and 6 more

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[marinofaggiana]

How you look the uploadedFile and the downloadStartFile are now very simple and reload the datasorce, because I found so many crashes here. Actually it should be revised because it is not optimized like this at all, but until we have an API with pagination it would be a waste of time.