Push Notification - TwoFactor Notification #2525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
marinofaggiana
changed the title
marinofaggiana
changed the title
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #2525 +/- ##
==========================================
+ Coverage 9.27% 9.32% +0.05%
==========================================
Files 185 185
Lines 25995 26026 +31
Branches 9715 9731 +16
==========================================
+ Hits 2411 2428 +17
- Misses 23364 23387 +23
+ Partials 220 211 -9
☔ View full report in Codecov by Sentry. |
mpivchev
reviewed
Jul 12, 2023
| @@ -280,11 +287,15 @@ class NCNotification: UITableViewController, NCNotificationCellDelegate, NCEmpty | |||
| self.notifications.remove(at: index) | |||
| } | |||
| self.tableView.reloadData() | |||
| if self.navigationController?.presentingViewController != nil, notification.app == NCGlobal.shared.twofactorNotificatioName { | |||
There was a problem hiding this comment.
twofactorNotificatioName is a typo -> twoFactorNotificationName
mpivchev
reviewed
Jul 12, 2023
mpivchev
reviewed
Jul 12, 2023
| @@ -32,7 +32,8 @@ class NCApplicationHandle: NSObject { | |||
|
|
|||
| // class: AppDelegate | |||
| // func nextcloudPushNotificationAction(data: [String: AnyObject]) | |||
| func nextcloudPushNotificationAction(data: [String: AnyObject]) { | |||
| func nextcloudPushNotificationAction(data: [String: AnyObject], completion: @escaping (_ detected: Bool) -> Void) { | |||
| completion(false) | |||
There was a problem hiding this comment.
Why is detected always false?
There was a problem hiding this comment.
was a old check (removed)
mpivchev
reviewed
Jul 12, 2023
| navigationController.modalPresentationStyle = .fullScreen | ||
| self.window?.rootViewController?.present(navigationController, animated: true) | ||
| } | ||
| } else if !findAccount { |
There was a problem hiding this comment.
Do we need the else if ? We can just do else
mpivchev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#867