Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements on Capabilities data #2539

Merged
merged 2 commits into from
Jul 18, 2023
Merged

improvements on Capabilities data #2539

merged 2 commits into from
Jul 18, 2023

Conversation

marinofaggiana
Copy link
Member

  • Capabilities have grown enormously and the SwiftyJSON proves terribly slow.
  • remove the SwiftyJSON and use the swift Codable JSONDecoder

Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
Signed-off-by: Marino Faggiana <marino@marinofaggiana.com>
Copy link
Collaborator

@mpivchev mpivchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I guess we still need SwiftyJSON for other parts?

@marinofaggiana
Copy link
Member Author

Nice! I guess we still need SwiftyJSON for other parts?

yes yes

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.20 ⚠️

Comparison is base (363772a) 9.25% compared to head (2f67dbc) 9.06%.

❗ Current head 2f67dbc differs from pull request most recent head 70f691d. Consider uploading reports for the commit 70f691d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #2539      +/-   ##
==========================================
- Coverage     9.25%   9.06%   -0.20%     
==========================================
  Files          185     185              
  Lines        26129   26272     +143     
  Branches      9775    9802      +27     
==========================================
- Hits          2419    2381      -38     
- Misses       23502   23689     +187     
+ Partials       208     202       -6     
Impacted Files Coverage Δ
iOSClient/Data/NCManageDatabase+Capabilities.swift 68.69% <75.00%> (+54.60%) ⬆️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marinofaggiana marinofaggiana merged commit 75f2b1a into develop Jul 18, 2023
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the capabilities branch July 18, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants