Merge pull request #884 from nextcloud/fix/a11y-copy-menu

fix(a11y): `Copy` menu entries should be implemented as buttons
nextcloud · Jun 21, 2023 · c4376eb · c4376eb
2 parents dad002f + a230095
commit c4376eb
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 9 deletions.
diff --git a/js/logreader-main.css b/js/logreader-main.css
diff --git a/js/logreader-main.css.map b/js/logreader-main.css.map
diff --git a/js/logreader-main.js b/js/logreader-main.js
diff --git a/js/logreader-main.js.map b/js/logreader-main.js.map
diff --git a/src/Components/LogTable.css b/src/Components/LogTable.css
@@ -115,7 +115,7 @@
 		margin: 0;
 		overflow: visible;
 
-		button {
+		> button {
 			position: relative;
 			opacity: 0;
 			transition: opacity 0.5s;

diff --git a/src/Components/LogTable.js b/src/Components/LogTable.js
@@ -89,16 +89,16 @@ export class LogTable extends Component {
 									className={style.copyMenu + ' popovermenu bubble open menu'}>
 									<ul>
 										<li>
-											<a className="menuitem icon icon-clippy"
+											<button className="menuitem icon icon-clippy"
 											   onClick={() => copyEntry(true)}>
 												{t('logreader', 'Copy raw')}
-											</a>
+											</button>
 										</li>
 										<li>
-											<a className="menuitem icon icon-clippy"
+											<button className="menuitem icon icon-clippy"
 											   onClick={() => copyEntry(false)}>
 												{t('logreader', 'Copy formatted')}
-											</a>
+											</button>
 										</li>
 									</ul>
 								</div> :