Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): Copy menu entries should be implemented as buttons #884

Merged
merged 1 commit into from Jun 21, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 6, 2023

The copy menu entries should be implemented using buttons instead of links without href set. No visual changes.

@susnux
Copy link
Contributor Author

susnux commented Jun 6, 2023

/compile amend

@susnux
Copy link
Contributor Author

susnux commented Jun 8, 2023

/backport to stable27

@icewind1991
Copy link
Member

/compile amend

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@icewind1991 icewind1991 merged commit c4376eb into master Jun 21, 2023
18 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/a11y-copy-menu branch June 21, 2023 15:43
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants