Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setupcheck for errors and warnings in log file #1021

Merged
merged 4 commits into from Nov 9, 2023

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Oct 12, 2023

Requires nextcloud/server#32550

Adds a SetupCheck for errors in the log file in the last 7 days.

  • Add link to logreader: not supported by server yet, postponed
  • Add link to documentation: supported, but do documentation would make sense here I think, postponed

@come-nc come-nc added this to the Nextcloud 28 milestone Oct 12, 2023
@come-nc come-nc self-assigned this Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (df9ce9f) 40.74% compared to head (ac41cde) 43.39%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1021      +/-   ##
============================================
+ Coverage     40.74%   43.39%   +2.65%     
- Complexity      159      168       +9     
============================================
  Files            25       26       +1     
  Lines           648      689      +41     
  Branches         31       31              
============================================
+ Hits            264      299      +35     
- Misses          384      390       +6     
Flag Coverage Δ
unit 25.14% <85.36%> (+5.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/AppInfo/Application.php 20.00% <0.00%> (-2.23%) ⬇️
lib/SetupChecks/LogErrors.php 87.50% <87.50%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@come-nc
Copy link
Contributor Author

come-nc commented Nov 7, 2023

@come-nc come-nc requested a review from susnux November 7, 2023 10:54
@come-nc come-nc marked this pull request as ready for review November 7, 2023 10:54
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the feat/add-setup-check-for-errors-in-log branch from 7f8e087 to 34cc3e1 Compare November 7, 2023 11:29
lib/SetupChecks/LogErrors.php Outdated Show resolved Hide resolved
Co-authored-by: Benjamin Gaussorgues <github-fa3ie@altahrim.net>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
@susnux susnux merged commit 162c36a into master Nov 9, 2023
24 checks passed
@susnux susnux deleted the feat/add-setup-check-for-errors-in-log branch November 9, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants