-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Menu toggle overlaps content #4956
Comments
screenshot? |
@GretaD could you have a look? I don't get it 🙈 @diemelone please try to be more elaborate with your suggestions. Describe what the problem was before and how it's better now. Also with screenshots of design changes it always helps to have a before/after. |
@ChristophWurst I think @diemelone talks about the overlapping hamburger button that you can see in the screenshot... |
yes @szaimen that is what i was talking about, it happens in different apps and mail was the first one i noticed. But it happens in other apps as well. |
Got it, thanks. @GretaD knows more about this as we tried to improve this in the past. |
@diemelone hello, |
No, the second column, where the envelops are shown - because of the padding added, one message is "gone" (in the end of the list) |
adding the same but negative amount at the end doesn't work? |
we are working on this ticket now, which means the envelopes will be even wider to fit the tags, which means that more messages will be gone in the end of the list. Im not saying your idea is bad or wrong, I just need our design lead to agree that we can "sacrifice" 2 messages to have the hamburger menu not overlapping. |
So the original issue @diemelone described is a duplicate of https://github.com/nextcloud/server/issues/16934#issuecomment-542201187 – with the solution described in my comment. :) So yes, basically we can add some padding at the top of the envelope list. If we like, we can additionally put something additional on the top there like:
|
"New Message" would fit there quite well I think, but to keep the overall similar design (e.g. calendar app) I wouldn't change that, instead the foldername like in the photos app would be a good visual fix. |
@jancborchardt did you read this? |
I also think that "delete message" "flagging" and local search would come in very very handy! (I find the frontends of sogo and afterlogic quite nice and good to work with...) |
for those that are looking for a quick and dirty fix I think I have got one... With a border-top that is 44px high everything works fine, I haven't lost any messages like mentioned before and no unwanted scrollbar is created. I used the custom css app. Screenshots: Padding fixpadding doesn't really do the trick as it only works for the first entry. Using margin creates an unwanted scrollbar.before scrolling: Screenshots: Border-top fixSo I added a border-top for the .app-content-list class, for demonstration purposes in redThe following css takes effect on multiple apps including mail and contacts. I haven't tried many more, so I don't know all apps that are effected. For the calendar app the second css code is relevant.
|
Thats a great fix. What i didn't see first, that this isnt a problem of mail app. It's problem of Nextcloud core CSS i think |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Currently there is a fix which makes it look halfway done, with there now being an empty "header bar" which is only there for the menu toggle: The proper solution would be to move the "New message" and "Refresh" buttons in from the navigation to that area as well, as specified in: #4956 (comment) |
please add
for
otherwise it is hidden behind the app-navigation-toggle
The text was updated successfully, but these errors were encountered: