Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with drafts [$65 awarded] #9

Closed
4 tasks done
jancborchardt opened this issue Aug 29, 2016 · 17 comments
Closed
4 tasks done

Issues with drafts [$65 awarded] #9

jancborchardt opened this issue Aug 29, 2016 · 17 comments
Labels
1. to develop bounty bug feature:drafts papercut Annoying recurring issue with possibly simple fix.
Milestone

Comments

@jancborchardt
Copy link
Member

jancborchardt commented Aug 29, 2016

There are a bunch of things problematic with drafts, and we should fix them. Cause drafts are a pretty helpful feature to save your stuff and sync it.

Sorted by severity:

  • For each email, a bunch of drafts are often saved and the previous one is not deleted
  • When an email is sent, the drafts of that email are not deleted
  • The subject isn’t saved
  • Special characters like umlauts and > is escaped which is horrible for quoted text

For later:


The $65 bounty on this issue has been claimed at Bountysource.

@koreywithak
Copy link

I use the Mail app with my Gmail account. I notice a few additional issues:

  1. When clicking on the [Gmail] subfolder and then Drafts, it will not load the draft e-mails. It does, however, load other subfolders, like Sent.
  2. When working on a new message or reply, it does save the draft into Drafts (although I can't view it in with the Nextcloud Mail app, due to above issue). However, it ends up saving multiple copies over the course of e-mail composition.

@keunes
Copy link

keunes commented Apr 18, 2017

I created an IMAP account with my hoster, and in their webmail (Roundcube) if I save a draft without a recipient, then Nextcloud Mail will say: "Something's wrong with loading your drafts :/" (manual translation). After adding a recipient in my hoster's Roundcube, Nextcloud Mail does load my drafts properly.


< nextcloud> < system> < version>11.0.2.7
< server> < webserver>Apache/2.4.25 (Raspbian)
< php> < version>7.0.16

@jrullo
Copy link

jrullo commented Apr 28, 2017

Is this solved? I have close to 200 draft emails in my mail app on nextcloud instance. I've replied to less than 10 mails that I can recall while using the mail app. I have no idea why so many drafts would be saved. I usually just read the mail and delete the ones I don't need.

@jancborchardt
Copy link
Member Author

@ChristophWurst @irgendwie @Gomez can anyone of you look into this? :) It’s one of the most annoying bugs I encounter daily. And it actually punishes the people who use the mail app a lot. :\

@jancborchardt jancborchardt added this to the 0.6.5 milestone May 23, 2017
@lcalaresu
Copy link
Member

Actually, no drafts are even saved on my environment using the master branch (it's working with the last stable version). The console gives me the message:

Uncaught (in promise) TypeError: Cannot read property 'draftUID' of undefined

It seems "this" has been used inside an anonymous function in js/views/composerview.js (lines 397 & 400) ; maybe use _this instead?

Does anyone reproduce this? It seems that these changes in the composerview are a bit old... Or maybe nobody uses the drafts 😄
At least, it solves the problem:

For each email, a bunch of drafts are often saved and the previous one is not deleted

😝

@jancborchardt
Copy link
Member Author

@lcalaresu if you can look into this it would be much appreciated. ;) I think @ChristopWurst said he doesn't use drafts so much.

@ChristophWurst
Copy link
Member

@lcalaresu if you can look into this it would be much appreciated. ;) I think @christopwurst said he doesn't use drafts so much.

No, I don't write any mails at all, you know 😛

@lcalaresu
Copy link
Member

@jancborchardt
Hehe I'm using draft a lot so, that one has interested me for a while (I could be selfish I guess ^^)
However, it looks super tricky! seems like big changes 😨
If people here are not afraid to answer all the questions I think I'm going to ask, no problem for me though

@jancborchardt
Copy link
Member Author

Sure, happy to help design & interaction-wise as far as I can, and I guess @ChristophWurst / @Gomez / @nextcloud/mail can answer technical questions. :)

@jospoortvliet jospoortvliet changed the title Issues with drafts Issues with drafts [$15] Jul 4, 2017
@jospoortvliet jospoortvliet changed the title Issues with drafts [$15] Issues with drafts [$65] Jul 6, 2017
@jancborchardt
Copy link
Member Author

Just added another 50$ to the bounty! :) Any takers?

@ChristophWurst ChristophWurst modified the milestones: 0.6.5, 0.7 Aug 2, 2017
@ChristophWurst
Copy link
Member

@jancborchardt could you please try the latest master (which includes #420) and check which is items have been fixed already? Thanks.

@jancborchardt
Copy link
Member Author

Will do as soon as I have the Nextcloud dev environment set up on my new laptop! :)

@ChristophWurst
Copy link
Member

Attachments are not saved
Drafts of replies are not shown automatically in the reply box when opening the mail again

Those two are wontfixes for 0.7. I've ticket the ones that I'm unable to reproduce, probably because #420 fixed them.

@ChristophWurst ChristophWurst added this to IN PROGRESS (max 2) in Christoph's Tasks Aug 23, 2017
@ChristophWurst ChristophWurst moved this from IN PROGRESS (max 2) to BACKLOG in Christoph's Tasks Aug 24, 2017
@jancborchardt
Copy link
Member Author

@ChristophWurst yup, totally fine. The only important one left is the

Special characters like umlauts and > is escaped which is horrible for quoted text

cause that breaks drafts quite hard.

@jancborchardt
Copy link
Member Author

Moved the two other issues which are for after 0.7 to:

@ChristophWurst
Copy link
Member

@ChristophWurst yup, totally fine. The only important one left is the

Special characters like umlauts and > is escaped which is horrible for quoted text

cause that breaks drafts quite hard.

As discussed, I've spent quite some time on debugging this and I've not yet found a way to fix the encoding.

@ChristophWurst ChristophWurst modified the milestones: 0.7, 0.7.1 Aug 25, 2017
@ChristophWurst ChristophWurst moved this from BACKLOG to SELECTED in Christoph's Tasks Aug 28, 2017
ChristophWurst added a commit that referenced this issue Aug 28, 2017
Apparently the horde libs do not produce a valid MIME unless you
actually use the 'send' method. Since they fortunatelly have a
null transport with an empty impl, we can use this to have the same
encoding magic going on as we do have in place for actually sending
messages via SMTP. Now drafts stored to IMAP are encoded correctly.

Fixes #9

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst moved this from SELECTED to TO REVIEW (max 4) in Christoph's Tasks Aug 29, 2017
@ChristophWurst ChristophWurst moved this from TO REVIEW (max 4) to DONE in Christoph's Tasks Aug 29, 2017
@jospoortvliet jospoortvliet changed the title Issues with drafts [$65] Issues with drafts [$65 awarded] Mar 7, 2018
@lock
Copy link

lock bot commented Nov 20, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and questions.

@lock lock bot locked and limited conversation to collaborators Nov 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1. to develop bounty bug feature:drafts papercut Annoying recurring issue with possibly simple fix.
Projects
No open projects
Development

No branches or pull requests

7 participants