Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding of drafts messages #476

Merged
merged 2 commits into from
Aug 29, 2017
Merged

Fix encoding of drafts messages #476

merged 2 commits into from
Aug 29, 2017

Conversation

ChristophWurst
Copy link
Member

Apparently the horde libs do not produce a valid MIME unless you
actually use the 'send' method. Since they fortunatelly have a
null transport with an empty impl, we can use this to have the same
encoding magic going on as we do have in place for actually sending
messages via SMTP. Now drafts stored to IMAP are encoded correctly.

Fixes #9

Apparently the horde libs do not produce a valid MIME unless you
actually use the 'send' method. Since they fortunatelly have a
null transport with an empty impl, we can use this to have the same
encoding magic going on as we do have in place for actually sending
messages via SMTP. Now drafts stored to IMAP are encoded correctly.

Fixes #9

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
Copy link
Member Author

Merged #473 into this to have CI test the new code too.

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Now at least the encoding errors are fixed! :)

@jancborchardt jancborchardt merged commit 30e069d into master Aug 29, 2017
@jancborchardt jancborchardt deleted the fix/drafts-encoding branch August 29, 2017 09:33
@ChristophWurst ChristophWurst moved this from TO REVIEW (max 4) to DONE in Christoph's Tasks Aug 29, 2017
@lock
Copy link

lock bot commented Nov 20, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and questions.

@lock lock bot locked and limited conversation to collaborators Nov 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants