Fix loading tags and clean up related tests #5078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
requested review from
st3iny,
kesselb,
miaulalala,
StCyr and
GretaD
StCyr
approved these changes
May 28, 2021
ChristophWurst
force-pushed
the
chore/clean-up-message-mapper-test
branch
from
66dea3b
to
0b70bbf
Compare
|
the sqlite integration test fails. let's see if it's really just sqlite or all dbs. locally with mariadb the test passes. |
* User self instead of $this for static method calls * Add assertion before accessign potentially undefined index * Improve typing Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
chore/clean-up-message-mapper-test
branch
from
0b70bbf
to
5b15b79
Compare
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
chore/clean-up-message-mapper-test
branch
from
5b15b79
to
3107726
Compare
ChristophWurst
changed the title
|
Nice one catching the string array bug. Weird that some databases allow query params with invalid types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instatements for Oracle Compliance #4947