New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bring back too many recipients check #7311
Draft
miaulalala
wants to merge
27
commits into
main
Choose a base branch
from
enh/add-recipients-check
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
miaulalala
force-pushed
the
enh/add-recipients-check
branch
3 times, most recently
from
October 9, 2023 16:28
ece4a32
to
f3ac92b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
24 tasks
miaulalala
force-pushed
the
enh/add-recipients-check
branch
from
February 26, 2024 10:03
c26c54a
to
403111a
Compare
Needs #9364 We already have a recipients check but it depends on the Anti Abuse Protection to be turned on. We can move the recipients check to be before we check for that to be enabled. Still needs the outbox status bc the exception won't bubble up so the mail will be sent regardless. To Do: Check if the recipient warning also expands groups (I don't think so), also needs a force option to send regardless. |
miaulalala
force-pushed
the
enh/add-recipients-check
branch
from
March 19, 2024 19:14
403111a
to
6dc7866
Compare
miaulalala
changed the title
Add recipients check
fix: bring back too many recipients check
Mar 19, 2024
and try resending failed messages at POF Signed-off-by: Anna Larch <anna@nextcloud.com>
Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
enh/add-recipients-check
branch
from
March 20, 2024 16:53
6dc7866
to
7eefdee
Compare
Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #9364
Fixes #6461