Improve loading experience for message on thread #7562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GretaD
force-pushed
the
fix/message-loading-screen
branch
from
4243dcc
to
f958e7f
Compare
Signed-off-by: greta <gretadoci@gmail.com>
Signed-off-by: greta <gretadoci@gmail.com>
Signed-off-by: greta <gretadoci@gmail.com>
Signed-off-by: greta <gretadoci@gmail.com>
GretaD
force-pushed
the
fix/message-loading-screen
branch
from
7b9a3f3
to
4997fd3
Compare
src/components/ThreadEnvelope.vue
Outdated
| @@ -490,6 +491,7 @@ export default { | |||
| margin-right: 10px; | |||
| background-color: var(--color-main-background); | |||
| padding-bottom: 28px; | |||
| min-height: 150px; | |||
There was a problem hiding this comment.
this doesn't seem to work. the message to iframe loader still causes a jump
|
the loading starts at sec 16 |
|
|
ahh, but thats the second icon(before the iframe content is shown) that i havent removed yet. You proposed to do it 3 prs and this is the second one. On this pr's description i added waht this pr does. |
| @@ -46,5 +46,16 @@ export default { | |||
| <style scoped> | |||
| #mail-content { | |||
| height: 450px; | |||
| animation: show 200ms 80ms cubic-bezier(0.38, 0.97, 0.56, 0.76) forwards; | |||
| opacity: 0.3; | |||
jancborchardt
requested changes
Nov 14, 2022
There was a problem hiding this comment.
Next to the jumping loading icon, 2 other things (possibly for other PRs, your call):
- The "Loading thread" message in the beginning is not needed, just show the loading thread directly
- The height of the container is still very small. Only mails which are just 1 sentence or word long will fit in there. So the default message container height (when the loading spinner is shown) can be increased. E.g. let's say that a mail with 5-7 lines of text could fit.
Signed-off-by: greta <gretadoci@gmail.com>
|
Superseded by #7615 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #6045
Add minimum height to element so the spinner looks less broken. This should be less than an action message
After the loading finished, animate that the element grows to the actual message size (especially text messages)