fix(neon_talk): Improve message list constraints

[provokateurin]

Fixes #1740

This not only adds the padding so that the scroll bar never overlaps the message time, but also moves the constraint into the list itself so that the scrollbar is always at the most right position regardless of the list width and you can scroll everywhere.

I didn't find any way to use SliverConstrainedCrossAxis because it aligns everything to the left but the messages should be centered. Maybe @Leptopoda you know what would make this work.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 28.63%. Comparing base (8f2f89d) to head (9017f74).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1849      +/-   ##
==========================================
- Coverage   28.63%   28.63%   -0.01%     
==========================================
  Files         197      197              
  Lines       67585    67586       +1     
==========================================
  Hits        19356    19356              
- Misses      48229    48230       +1     

Flag	Coverage Δ		*Carryforward flag
dynamite	44.18% <ø> (ø)		Carriedforward from 8f2f89d
dynamite_end_to_end_test	61.38% <ø> (ø)		Carriedforward from 8f2f89d
dynamite_runtime	82.65% <ø> (ø)		Carriedforward from 8f2f89d
neon_dashboard	92.56% <ø> (ø)
neon_framework	37.61% <0.00%> (-0.02%)	⬇️
neon_talk	100.00% <ø> (ø)
nextcloud	25.76% <ø> (ø)		Carriedforward from 8f2f89d

*This pull request uses carry forward flags. Click here to find out more.

Files	Coverage Δ
...n_framework/lib/src/models/app_implementation.dart	0.00% <0.00%> (ø)

[Leptopoda]

I didn't find any way to use SliverConstrainedCrossAxis because it aligns everything to the left but the messages should be centered. Maybe @Leptopoda you know what would make this work.

I don't know of any way to make it work with a SliverConstrain
This boils down to the question of what you actually what to constrain. The chat view or the messages themselves?
If we ever want to implement a chat bubble UI (like Signal/WhatsApp use) you do not actually want to constrain the chat list as the bubbles should be alligned to the edges of the list/screen.
In this case I'd rather just put the old Center/ConstrainedBox inside the TalkMessage widget.

[provokateurin]

Only the messages should be constrained. Right now I just constrained the whole sliver, but I guess constraining the individual messages is also possible. Then the padding can be applied to the whole list and it's separate from the width constraint.

[provokateurin]

I couldn't find any other way to make it work, using ConstrainedBox on the TalkMesssage widget has no effect (but I don't understand why).

[Leptopoda]

talk_constraints.patch.txt

This ontop of this branch works for me. Or are you trying to achieve something different?

[provokateurin]

I almost had the same patch as you sent, but it didn't work. Now it did 🤷‍♀️